Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe test cases may result in unexpected failure #241

Closed
aShinjiroUrata opened this issue Nov 20, 2017 · 8 comments
Closed

subscribe test cases may result in unexpected failure #241

aShinjiroUrata opened this issue Nov 20, 2017 · 8 comments
Labels

Comments

@aShinjiroUrata
Copy link
Contributor

Test case 0180-subscribe-success.html
(https://github.com/aShinjiroUrata/web-platform-tests/blob/dev-urata-vsss-test/vehicle/viss/0180-subscribe-success.html)
may result in unxpected failure even when subscribe itself succeed and the test criterion is satisfied.

This happend in test suite execution with ETRI's VISS implementation.
This does not happened with ACCESS's implementation.

aShinjiroUrata added a commit to aShinjiroUrata/web-platform-tests that referenced this issue Nov 20, 2017
(w3c/automotive#241)
- Fixed by adding code to ignore SubscriptionNotificationResponse/ErrorResponse
  after Unsubscibe request has been sent to VISServer.
@aShinjiroUrata
Copy link
Contributor Author

The test failure can happen by following scenario.

1)Testcase0180 send subscribe request to VISServer
2)Receives SubscribeSuccessResponse and some SubscriptionNotification
3)Then Testcase0180 send unsubscribe request to VISServer
4)After that, Testcase0180 expects to receive UnsubscribeSuccessResponse
and if receives any other response from VISServer, judge it as 'Failure'.
5)However, even after unsubscribe request has been sent to VISServer,
some remaining SubscriptionNotification can reach to client and this is not errorneous behavior.
But this is judged as Failure by 4) logic.

This issue can be fixed by ignoring SubscriptionNotifications reached to client after unsubscribe request has been sent.

@aShinjiroUrata
Copy link
Contributor Author

aShinjiroUrata commented Nov 20, 2017

Bug fixed by following commit.
aShinjiroUrata/web-platform-tests@2ad5d41

Fixed simmilar issues in following testcases in this commit as well.
0180, 0190, 0240, 0250, 0260,

@wonsuk73
Copy link
Contributor

@aShinjiroUrata Thanks for the work.
Right before I have done the test with your revised version of test cases. Unfortunately I got fail result like previous one. I will share the screen shots with you via email.

aShinjiroUrata added a commit to aShinjiroUrata/web-platform-tests that referenced this issue Nov 24, 2017
(w3c/automotive#241)
- Remove non necessary 'assert_true'
- Added some value check
@aShinjiroUrata
Copy link
Contributor Author

I received report from @wonsuk73 that, test 0180 passed after below change.

aShinjiroUrata/web-platform-tests@76e8918

@aShinjiroUrata
Copy link
Contributor Author

Also reported test 0200 fails with similar reason to 0180 failure which is

  • Test0200 send several 'Subscribe request' to VISServer.
  • Then test0200 wait for 'SubscribeSuccessResponse' or 'SubscribeErrorResponse'.
  • However at this point, test0200 receives 'SubscriptionNotification' message and it judges as test failure.
    (Test0200 can ignore 'SubscriptionNotification' since it does not relevant to test criterion.)

aShinjiroUrata added a commit to aShinjiroUrata/web-platform-tests that referenced this issue Nov 27, 2017
(w3c/automotive#241)
- Changed to ignore 'SubscriptionNotification' messages since not relevant to test criterion.
@aShinjiroUrata
Copy link
Contributor Author

For test 0200, following change has been done.

aShinjiroUrata/web-platform-tests@760c51b

@wonsuk73
Copy link
Contributor

Thanks @aShinjiroUrata ! It's working well!

@aShinjiroUrata
Copy link
Contributor Author

Thanks for the feedback.
In this issue, 0180, 0200 problems are reported, fixed and verified.
I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants