Revised JSON schema for subscribeRequest and unsubscribe interface #171 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding issue #171 it had been revised for - JSON schema of subscribeRequest in subscribe interface - JSON schema of unsubscribeRequest, unsubscribeSuccessResponse and unsubscribeErrorResponse in unsubscribe interface
|
@wonsuk73, makes logically sense since the JSON schema allows a null value for subscriptionId, which means it can be made optional. |
|
@rstreif Thanks for your opinions! Empty subscrptionId is used only for unsubscribeAll action! for removing all of subscription at one time. I think if that is used in any case related with unsubscribe action, that might be wrong. |
|
Thanks @wonsuk73. I agree, this is clearer and more logical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #171 it had been revised for