Allow unicode in baggage keys by referencing XML #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
force-pushed
the
unicode-keys-external-def
branch
3 times, most recently
from
04aa2b3
to
2455c92
Compare
|
@plehegar any idea why the preview is broken for this PR? Build works fine locally |
basti1302
force-pushed
the
unicode-keys-external-def
branch
from
2455c92
to
ad57816
Compare
basti1302
approved these changes
Jun 20, 2023
kalyanaj
reviewed
Jun 20, 2023
| @@ -45,7 +42,8 @@ Producers SHOULD try to produce a `baggage-string` without any `list-member`s wh | |||
|
|
|||
| #### key | |||
|
|
|||
| A `token` which identifies a `value` in the `baggage`. `token` is defined in [RFC7230, Section 3.2.6](https://tools.ietf.org/html/rfc7230#section-3.2.6). | |||
| A `key` which identifies a `value` in the `baggage`. | |||
There was a problem hiding this comment.
This sentence feels a bit ambiguous (key identifying a value) and is also not complete; instead, can we remove this sentence and instead add to the definitions list something like:
key = token ; as defined in Name in [[XML]]
and then in the ####key section maybe we can have:
token is defined as Name in [[XML]], Section 2.3: https://www.w3.org/TR/xml/#NT-Name.
|
Closing this as this is no longer applicable per recent WG decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #117 which relies on an external definition for keys
Preview | Diff