Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unicode in baggage keys by referencing XML #120

Closed
wants to merge 1 commit into from
Closed

Allow unicode in baggage keys by referencing XML #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions baggage/HTTP_HEADER_FORMAT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ baggage-string = list-member 0*179( OWS "," OWS list-member )
list-member = key OWS "=" OWS value *( OWS ";" OWS property )
property = key OWS "=" OWS value
property =/ key OWS
key = token ; as defined in RFC 7230, Section 3.2.6
value = *baggage-octet
baggage-octet = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
; US-ASCII characters excluding CTLs,
Expand All @@ -32,8 +31,6 @@ baggage-octet = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
OWS = *( SP / HTAB ) ; optional white space, as defined in RFC 7230, Section 3.2.3
```

`token` is defined in [[!RFC7230]], Section 3.2.6: https://tools.ietf.org/html/rfc7230#section-3.2.6

The definition of `OWS` is taken from [[RFC7230]], Section 3.2.3: https://tools.ietf.org/html/rfc7230#section-3.2.3

#### baggage-string
Expand All @@ -45,7 +42,8 @@ Producers SHOULD try to produce a `baggage-string` without any `list-member`s wh

#### key

A `token` which identifies a `value` in the `baggage`. `token` is defined in [RFC7230, Section 3.2.6](https://tools.ietf.org/html/rfc7230#section-3.2.6).
A `key` which identifies a `value` in the `baggage`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence feels a bit ambiguous (key identifying a value) and is also not complete; instead, can we remove this sentence and instead add to the definitions list something like:

key = token ; as defined in Name in [[XML]]

and then in the ####key section maybe we can have:

token is defined as Name in [[XML]], Section 2.3: https://www.w3.org/TR/xml/#NT-Name.

`key` is defined as `Name` in [[XML]], Section 2.3: https://www.w3.org/TR/xml/#NT-Name
Leading and trailing whitespaces (`OWS`) are allowed and are not considered to be a part of the key.

#### value
Expand Down