-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in Example 1 code #61
Comments
Thanks! fixed. |
Thanks for the fast fix!
|
Oh, @zurmuehl can you be a hero and send a pull request for them? I just did the edit directly on github. |
No, I've not fixed them yet :) Only one.
…On April 23, 2018 at 9:43:33 PM, Martin Zurmuehl ***@***.***) wrote:
Hi Marcos,
I have reported 3 additional tyes in #61. Have you already fixed them too? So far I didn’t
see them on github.
After you fixed them I will crated a pull request. Rookie question: What are the correct
base branch and head branch for the pull request?
Thanks
Martin
From: Marcos Cáceres ***@***.***
Sent: Montag, 23. April 2018 13:14
To: w3c/beacon
Cc: Zurmuehl, Martin ; Mention
Subject: Re: [w3c/beacon] Typo in Example 1 code (#61)
Oh, @zurmuehl can you be a hero and send a pull request
for them? I just did the edit directly on github.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub,
or mute the thread.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#61 (comment)
|
zurmuehl
added a commit
to zurmuehl/beacon
that referenced
this issue
Apr 23, 2018
Pull request created. |
marcoscaceres
pushed a commit
that referenced
this issue
Apr 23, 2018
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the beacon spec. in the introduction section in example 1 the coding line
if (document.visiblityState === 'hidden') contains a typo: visiblityState should read visibilityState
The text was updated successfully, but these errors were encountered: