Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Example 1 code #61

Closed
zurmuehl opened this issue Apr 23, 2018 · 5 comments
Closed

Typo in Example 1 code #61

zurmuehl opened this issue Apr 23, 2018 · 5 comments

Comments

@zurmuehl
Copy link
Contributor

In the beacon spec. in the introduction section in example 1 the coding line
if (document.visiblityState === 'hidden') contains a typo: visiblityState should read visibilityState

@marcoscaceres
Copy link
Member

Thanks! fixed.

@zurmuehl
Copy link
Contributor Author

Thanks for the fast fix!
Unfortunately there are 3 other places where 'visibilityState' is misspelled as 'visiblityState':

  1. In the note under example 1 in the brackets: '(i.e. visiblityState equal to hidden).'
  2. The last word in section 2.1 'visiblityState'.
  3. In section 3.1 second bullet point: '... when the document visiblityState transitions to...'

@marcoscaceres marcoscaceres reopened this Apr 23, 2018
@marcoscaceres
Copy link
Member

Oh, @zurmuehl can you be a hero and send a pull request for them? I just did the edit directly on github.

@marcoscaceres
Copy link
Member

marcoscaceres commented Apr 23, 2018 via email

@zurmuehl
Copy link
Contributor Author

Pull request created.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants