-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate link. Add note about inclusive language. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Link checker flagged a duplicate link, fixed here. - Pubrules warned about inclusive langauge use of the words "he", "his", and "her". I performed a complete search of the document. The terms "his" and "her" appear in the example of Hispanic names in section 9.3.4. The term "he" also appears there. However, "he" appears throughout the document in the form of a language tag. To address, I added an HTML comment (not visible in the text) to remind ourselves in the future. We might consider providing an in-text note about inclusivity.
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
xfq
approved these changes
Jul 21, 2023
r12a
reviewed
Jul 21, 2023
r12a
reviewed
Jul 21, 2023
- Fix spelling error in the comment - Add postProcess for local.css - Fix broken link to css-counter-styles (it is required to be `css-counter-styles-3` by specref) Note that the postProcess import of the stylesheet does not work on the local copy, only from the repo, because of XSS prevention.
Having discussed it with Richard, updated the styles here along with all of the text. This includes: - Adding a link to respec_2022.css - Removing some styles from local.css that are in that sheet - Fix loading local.css - Adding instructions to the local.css stylesheet - Update the character naming styles - Add a demo image (00A0.png) in an images directory - Fix the echidna manifest for eventual publication - Clean up the text per discussion with @r12a
@r12a Please have a look. I made the changes we just discussed here first, since this is supposed to be the source for the stuff in tr-design (and it impacts the linking stuff we also discussed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link checker flagged a duplicate link, fixed here.
Pubrules warned about inclusive langauge use of the words "he", "his",
and "her". I performed a complete search of the document. The terms
"his" and "her" appear in the example of Hispanic names in section
9.3.4. The term "he" also appears there. However, "he" appears
throughout the document in the form of a language tag.
To address, I added an HTML comment (not visible in the text) to
remind ourselves in the future. We might consider providing an
in-text note about inclusivity.
Preview | Diff