Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #202 Errata reported by @shujikamitsuna #203

Merged
merged 10 commits into from
Sep 17, 2020
Merged

Conversation

aphillips
Copy link
Contributor

@aphillips aphillips commented Sep 4, 2020


💥 Error: 403 Forbidden 💥

PR Preview failed to build. (Last tried on Sep 17, 2020, 4:13 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

🔗 Related URL


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
<head><title>HTML Diff service</title>
<link rel="stylesheet" href="http://www.w3.org/StyleSheets/base" />
</head>
<body>

<p><a href="http://www.w3.org/"><img src="http://www.w3.org/Icons/w3c_home" alt="W3C"/></a> <a href="http://www.w3.org/2003/Editors">W3C Editors homepage</a></p>

<h1>Create Diff between HTML pages</h1>

<p style='color:#FF0000'>An error (403 Forbidden) occured trying to get <a href='https://pr-preview.s3.amazonaws.com/w3c/charmod-norm/pull/203/91418dc.html'>https://pr-preview.s3.amazonaws.com/w3c/charmod-norm/pull/203/91418dc.html</a>.</p>

<form method="GET">
<p>Address of reference document: <input name="doc1" type="url" value="https://pr-preview.s3.amazonaws.com/w3c/charmod-norm/pull/203/91418dc.html" style="width:100%"/></p>
<p>Address of new document: <input name="doc2" value="https://pr-preview.s3.amazonaws.com/aphillips/charmod-norm/pull/203.html"  style="width:100%"/></p>
<p><input type="submit" value="get Diff"/></p>
</form>

<p><strong>Tip</strong>: if the document uses the W3C convention on linking to its previous version, you can specify only the address of the new document — the previous link will be automatically detected.</p>
<h2>Diff markings</h2>
<p>This service relies on <a href="https://www.gnu.org/software/diffutils/">GNU diff</a>. The found differences are roughly marked as follow:
<ul>
<li>deleted text is shown in pink with down-arrows (as styled for a &lt;del> element)</li>
<li>where there is replacement, it’s shown in green with bi-directional arrows,</li>
<li>where there is newly inserted text, it’s yellow with up arrows (&lt;ins> element)</li>
</ul>
<address>
script $Revision$ of $Date$<br />
by <a href="http://www.w3.org/People/Dom/">Dominique Hazaël-Massieux</a><br />based on <a href="https://github.com/w3c/htmldiff-ui/blob/master/htmldiff.pl">Shane McCarron’ Perl script</a> wrapped in a <a href="https://github.com/w3c/htmldiff-ui/blob/master/htmldiff">Python CGI</a>
</address>
</body>
</html>


If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@xfq
Copy link
Member

xfq commented Sep 5, 2020

The errata part looks good to me. The "Specifying Content Restrictions" part seems unrelated to the errata?

@aphillips
Copy link
Contributor Author

LGTM. Please submit a PR.

But Richard, this is a PR... :-)

@xfq: Yes, I should have branched when submitting the proposal for action-947

Includes:
* Definition of "application internal identifier" and "user-facing identifier" terms
* Addition of a C0/C1 control restriction
* Re-definition from the "full range of Unicode" to the *non* restriction to ASCII.
* Additional editing and refactoring.
index.html Outdated
<p>One of the ways in which string matching can be made more effective and consistent is by applying restrictions to the content that is to be matched. Document formats and protocols often do this by defining a namespace or set of rules for what is legal in a given context.</p>
<p>One of the ways in which string matching can be made more effective and consistent is by applying restrictions to the content that is to be matched. When building a <a>vocabulary</a> and especially when defining <a>user-supplied values</a> within that vocabulary, specifications for document formats and protocols often define a namespace or set of rules for what is legal in a given context. This usually includes length and content restrictions.</p>

<p class="requirement"><span class="qrec">[S]</span> Specifications SHOULD NOT allow the <code>C0</code> (<span class=uname>U+0000</span> to <span class=uname>U+001F</span>) and <code>C1</code> (<span class=uname>U+0080</span> to <span class=uname>U+009F</span>) control characters.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the context of this guidance? I think in context like HTML phrasing content, control characters should be allowed. If it refers to identifiers, we should mention that.

Another question: should we allow surrogates and noncharacters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the context of identifiers. I can clarify.

Unpaired surrogates and non-character code points are mostly handled by data types such as DOMString or definitions in the Infra spec. It's not wrong to ban them here, though. You heard us struggling with describing the rules in the teleconference. Anyway, point taken: more work is needed here.

index.html Outdated

<p>There are two broad classes that strings or identifier types fall into: those that are meant to be seen, read, or interacted with by humans (and thus might be expected to contain natural language text); and those that are application or protocol internal and not intended for human interaction.</p>
<p>There are two broad classes of identifer: <a>user-facing identifiers</a> and <a>application internal identifiers</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"identifer" should be "identifier" or "identifiers" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@aphillips aphillips merged commit e70fe7f into w3c:gh-pages Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants