Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Terminology section normative #91

Closed
wants to merge 6 commits into from

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Sep 2, 2024

That the Terminology is normative is a matter of fact. It would be strange and confusing for us to say otherwise in the specification.

Per my comment at , the fact that the Terminology is normative is independent of whether we choose to test statements in the specification that don't contain "MUST".

Fixes #46

Cc: @jyasskin


Preview | Diff

selfissued and others added 6 commits August 31, 2024 12:10
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@iherman
Copy link
Member

iherman commented Sep 3, 2024

We have a family of recommendations, and consistency among those matters. If the terminology section is normative in this specification, it should be in all others and, conversely, if they are not normative in others, then I am opposed to make an exception in this specification.

I note that we do have a discrepancy already, which we should address. Indeed, the terminology section in VCDM is normative, whereas the same section in DI is non-normative. (I did not check all the specs in the family.)

Personally, I'd probably prefer to have normative terminology sections everywhere, but that should be a WG decision.

@selfissued
Copy link
Collaborator Author

Terminology is normative in VCDM and VC-JOSE-COSE. VC-DATA-INTEGRITY is the odd man out in this regard.

@msporny msporny added the normative This item is a normative change. label Sep 4, 2024
@dlongley
Copy link
Contributor

dlongley commented Sep 4, 2024

Note that VC 1.1 terminology used to be non-normative:

https://www.w3.org/TR/vc-data-model/#terminology

I'm not sure when / where that got changed in 2.0, it might be a mistake.

EDIT: This PR made the VCDM change: w3c/vc-data-model#1357

@iherman
Copy link
Member

iherman commented Sep 4, 2024

The issue was discussed in a meeting on 2024-09-04

  • no resolutions were taken
View the transcript

2.1. Make Terminology section normative (pr controller-document#91)

See github pull request controller-document#91.

Brent Zundel: most things should be on the PR.
… 91 is about making the Terminology Section being normative raised by Mike Jones.

Manu Sporny: this is a regular request from Jeffrey Yasskin.
… the idea is that if it's not normative, something bad happens.
… it's a philosophical question.
… our group says there must be MUST, SHOULD style language.
… traditionally, we don't have that in terminology sections.
… so we haven't marked them as normative as it does not effect tests.
… doing so has no effect, so I don't think we should do it.
… given it lacks RFC style language.

Brent Zundel: one, manu's right, we've never marked out terminology section as normative.
… on the other hand, if it changes nothing other than makes some other people happy, maybe we just do it.

Ivan Herman: consistency is important as manu has said.
… I always found more natural for this section to be normative.
… but on the other hand the group can decide.
… but I also agree with brent that doing is harmless and removes contention.

Michael Jones: as I said in the issue, there are two different things.
… if it's normative, it's a matter of fact.
… it being normative doesn't require there being RFC language.

Ivan Herman: +1 to selfissued.

Michael Jones: there's a normative statement..."the entity identified by the id property in the controller document"--that's normative.
… I'm not OK saying that something false can be in the document.
… we already use a normative terminology on JOSE/COSE.

Manu Sporny: I'll repeat again, this will have zero effect.
… this will not effect anything. not tests. not implementations. none of that, so it's unnecessary.
… but if people really want to do this, we can, but it will have no effect.

Brent Zundel: I'm not interested in a philosophical debate.
… it seems like a simple course of action.

Dave Longley: +1 ok with the change.

Brent Zundel: those who don't care can continue not caring.

Ivan Herman: +1 to brent.

Brent Zundel: I think we can merge this since it will be harmless.

Ivan Herman: just emphasizing that we need to be consistent.

Brent Zundel: selfissued, can you make the necessary PRs.

Michael Jones: yes.

Brent Zundel: any formal objections?

@msporny
Copy link
Member

msporny commented Sep 8, 2024

Due to a number of previous merges, this PR now has merge conflicts.

I have manually implemented the PR in this commit 568f387, making the Terminology section normative.

Closing this PR as it has been applied via commit 568f387.

@msporny msporny closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
normative This item is a normative change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sections marked informative should be normative
5 participants