Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-typed-om] Add missing font units to CSSNumericFactory #1106

Closed
nt1m opened this issue Aug 29, 2023 · 1 comment · Fixed by #1107
Closed

[css-typed-om] Add missing font units to CSSNumericFactory #1106

nt1m opened this issue Aug 29, 2023 · 1 comment · Fixed by #1107

Comments

@nt1m
Copy link
Member

nt1m commented Aug 29, 2023

https://drafts.css-houdini.org/css-typed-om-1/#numeric-factory

These are missing cap / rcap / rch / rex / ric
@nt1m nt1m transferred this issue from w3c/csswg-drafts Aug 29, 2023
@nt1m nt1m mentioned this issue Aug 29, 2023
Merged
@nt1m nt1m mentioned this issue Aug 29, 2023
Merged
@nt1m
Copy link
Member Author

nt1m commented Aug 29, 2023

WPT are at: web-platform-tests/wpt#41705

webkit-commit-queue pushed a commit to nt1m/WebKit that referenced this issue Aug 30, 2023
@nt1m
[css-typed-om] Add factory functions for all font relative units
610cae5 
https://bugs.webkit.org/show_bug.cgi?id=260760
rdar://114482930

Reviewed by Darin Adler.

Add new font and root font relative lengths to CSSNumericFactory.

Houdini issue: w3c/css-houdini-drafts#1106

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length.html: Added.
* Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl:

Canonical link: https://commits.webkit.org/267437@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[css-typed-om] Add missing font units to CSS numeric factory w3c/css-houdini-drafts
1 participant
@nt1m