Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-properties-values] Apply hook triggering new style resolution? #42

Closed
FremyCompany opened this issue Sep 14, 2015 · 2 comments
Closed

Comments

@FremyCompany
Copy link
Contributor

During last meeting, Tab told that to accomodate changes made in the ApplyHook of css-propvals, a new round of style computation and resolution would happen to fix anything that would not be computed-compatible added by the hook.

To me, this means we've made something which is not a primitive of the web browser, but a new feature that will add more complexity to the system.

I propose we mark the ApplyHook as at-risk until we develop a ComputedStyle TypedOM and restrict the value of properties set in the ApplyHook to those values, in order to avoid any style recalc after this step.

@tabatkins
Copy link
Member

We received pushback during the meeting about that, and explicitly decided against it; the ApplyHook has to emit Computed-ready values (lengths are only px, percent, or keywords, etc) or else it's an error.

@FremyCompany
Copy link
Contributor Author

Thanks for clarifying. That's mostly what I proposed at the end of the message.
I would tentatively be in favor of the ApplyHook take a dependency on the TypeOM because if the set of values it can take and receive both express cleanly in the set of values the new OM is supposed to accept, it would be a mistake to make it work on strings.

Could we update this issue to cover this proposal (I take on me to edit the message and title accordingly), or would you prefer me to open a new one?

majido pushed a commit to majido/css-houdini-drafts that referenced this issue Aug 8, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants