-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-typed-om-1] Is it intentional that only existing items in a CSSUnparsedValue can be mutated? #664
Comments
Both of the readwrite indexed things need another pass by me to fill in these details. It's unclear from the WebIDL spec how one is supposed to handle these, and specs disagree in ways that confuse me. In particular, a lot of indexed-getter/setter interfaces have the getter return a nullable value, presumably with the idea that if you request a non-existent index you get back |
Your typical nullable-supporting indexed getter looks something like this:
That means it can be invoked as When invoked as When invoked as In your case, since your getters are identifier-less, you don't need to worry about the direct call case and can assume you will always be invoked with in-range indices. |
In other words, if the getter above were:
then it could not be invoked other than as |
Ahhhh, that explains some stuff. Thanks! |
This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f
This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537691}
This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537691}
This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537691}
…rsedValue., a=testonly Automatic update from web-platform-tests[css-typed-om] Allow mutations of CSSUnparsedValue. This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537691} wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572
…rsedValue., a=testonly Automatic update from web-platform-tests[css-typed-om] Allow mutations of CSSUnparsedValue. This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainarchromium.org> Commit-Queue: Darren Shen <shendchromium.org> Cr-Commit-Position: refs/heads/master{#537691} wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 UltraBlame original commit: 2618adb9143793bed62609bbe12f803f7e605711
…rsedValue., a=testonly Automatic update from web-platform-tests[css-typed-om] Allow mutations of CSSUnparsedValue. This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainarchromium.org> Commit-Queue: Darren Shen <shendchromium.org> Cr-Commit-Position: refs/heads/master{#537691} wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 UltraBlame original commit: 2618adb9143793bed62609bbe12f803f7e605711
…rsedValue., a=testonly Automatic update from web-platform-tests[css-typed-om] Allow mutations of CSSUnparsedValue. This patch allows CSSUnparsedValue items to be mutated/appended. See w3c/css-houdini-drafts#664 Bug: 812919 Change-Id: I3e3c1d91fa9bfaa3a1a4adde45202c36c9bdb37f Reviewed-on: https://chromium-review.googlesource.com/923670 Reviewed-by: nainar <nainarchromium.org> Commit-Queue: Darren Shen <shendchromium.org> Cr-Commit-Position: refs/heads/master{#537691} wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 wpt-commits: 8fed98324bc133df221d778c62cbff210d43b0ce wpt-pr: 9572 UltraBlame original commit: 2618adb9143793bed62609bbe12f803f7e605711
There is an indexed setter, but no indexed creator. So you can mutate the existing list of values, but not extend the list.
(There is also no deleter, but Web IDL no longer supports indexed deleters to start with, so that would be a bit complicated. In an ideal world, though, one could change the length of the list in various ways.)
The text was updated successfully, but these errors were encountered: