Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] should 'place-items' accept 'legacy' values? #1449

Closed
dbaron opened this issue May 22, 2017 · 3 comments
Closed

[css-align] should 'place-items' accept 'legacy' values? #1449

dbaron opened this issue May 22, 2017 · 3 comments

Comments

@dbaron
Copy link
Member

dbaron commented May 22, 2017

The Value line for the place-items shorthand says that it takes an auto value for the justify-items part of the shorthand. However, justify-items doesn't take such a value; I believe this was intended to be the value that has been renamed to legacy.

(Is it intended that values like legacy left aren't supported in the shorthand?)

@dbaron dbaron added the css-align-3 Current Work label May 22, 2017
@fantasai
Copy link
Collaborator

Ok, I dropped the auto keyword from the value line. Whether we should allow the various legacy values/combos is an open question. I'd lean towards no, but don't have a strong opinion.

@fantasai fantasai changed the title [css-align] 'place-items' value line says it takes 'auto', but should be 'legacy' [css-align] should 'place-items' accept 'legacy' values? Jun 15, 2017
Loirooriol pushed a commit to Loirooriol/csswg-drafts that referenced this issue Jun 18, 2017
@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed should 'place-items' accept 'legacy' values?, and agreed to the following resolutions:

  • RESOLVED: leave behavior as-is and not accept legacy values for place-items
The full IRC log of that discussion <dael> Topic: should 'place-items' accept 'legacy' values?
<tantek> you can post up to 4 photos/diagrams per tweet fantasai :)
<dael> github: https://github.com//issues/1449
<dael> fantasai: I don't have an opinion, it's question of show we have the shorthand for various legacy items of justify:items. It takes legacy as a keyword alone or in combo of other values. Do we want iit in the shorthand.
<dael> TabAtkins: I'm on the side of no. There's no real reason for authers to specify that for themselves.
<dael> Rossen_: The legacy one should be left for legacy.
<dael> dbaron: One of the tradeoffs is that it becomes harder to serialize to the shorthand. You end up with cases where you can't serialize the shorthand
<dael> TabAtkins: I'm not sure. But only if you have the place item shorthand on a center element, I think. So...ehh.
<dael> Rossen_: dbaron would you object if we didn't?
<fantasai> Don't we already have othe rcases where there are values that aren't possible to express in the shorthand?
<dael> dbaron: I'm okay, I jsut wanted to bring that up
<dael> Rossen_: I heard fantasai and dbaron being okay with...fanwas fine with either, dbaron would be okay if we stayed with current version. 2 others voted stay with current. Other opinions?
<fantasai> what's current?
<dael> Rossen_: Objections to leaving behavior as-is and not accept legacy values for place-items
<dael> RESOLVED: leave behavior as-is and not accept legacy values for place-items

@tabatkins
Copy link
Member

Since there's nothing left to do here, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants