New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] Rename `auto` to `legacy` for `justify-items` #1318

Closed
fantasai opened this Issue May 2, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@fantasai
Contributor

fantasai commented May 2, 2017

In the align-self and justify-self properties, the auto keyword looks up to the parent's align-items or justify-items property. That's fine.

On justify-items we also have an auto keyword, but it's not there for the general case: it's just there to handle some special computation in case the parent’s value contains a legacy keyword alongside an alignment keyword.

It would be equally plausible to just use legacy as this magic-computing keyword, and leave auto out of the property entirely. Note that align-items doesn't have an auto keyword, because it doesn't have legacy.

Proposal A is to rename auto to legacy.
Proposal B is to remove legacy entirely and leave the handling of <CENTER> and friends to UA-specific magic and/or a separate (Yet Another) alignment property.

@fantasai

This comment has been minimized.

Contributor

fantasai commented May 2, 2017

Note: We edited Proposal A into the latest ED for comparison.

@rachelandrew

This comment has been minimized.

Contributor

rachelandrew commented May 3, 2017

A preference for Proposal A from me. Where you do see people getting <CENTER> into their markup is where they are using some horrible WYSIWYG CMS editor that lets content editors add it. It seems that having the ability to deal with this in a known fashion from CSS is going to be helpful to authors trying to do modern web development while having to cope with this kind of thing.

I like legacy as a keyword as that is a good way to explain it, this isn't behaviour that we want to be using for any other purposes than to deal with an old way of formatting that still lurks around.

@css-meeting-bot

This comment has been minimized.

Member

css-meeting-bot commented May 10, 2017

The CSS Working Group just discussed Rename `auto` to `legacy` for `justify-items` Pending this resolution we could go to CR, and agreed to the following resolutions:

  • RESOLVED: rename auto to legacy.
  • RESOLVED: Move CSS Alignment to CR with the added legacy value defined as at-risk. The action of starting the CR process will start in 2 weeks (May 27) unless we heard elsewise.
The full IRC log of that discussion <dael> Topic: Rename `auto` to `legacy` for `justify-items` Pending this resolution we could go to CR
<dael> Github topic: https://github.com//issues/1318
<fantasai> https://software.hixie.ch/utilities/js/live-dom-viewer/saved/5143
<dael> fantasai: we've got different behavior on different browsers (still on previous issue).
<dael> fantasai: Alignment spec has a bunch of keyword magic with justify-items. It sets default value of justify self for any children. We tried to figure out how to incorporate center tag and did it with a special set of keywords called legacy with an intial value of auto. All auto does is this magic, but we could just uselegacy keword by itself
<dael> fantasai: Proposal is rename auto to legacy so all it does is if you have legacy keyword on parent it pulls the parent alignment, else does normal thing.
<dael> fantasai: Alternate is drop t his thing.
<dael> fantasai: We haven't gotten any significant comments. Apperently style stuff is implin chrome. Not sure how people are imple center and align attributes in HTML.
<dael> fantasai: If impl don't want to implement center and align attributes through this we should drop. If we want to keep it we recommend the rename.
<dael> fantasai: Did that make sense or do we need more explination?
<dael> Rossen: Your explination was great. In ourimpl we handle center a little magic. Rename would be okay. Trying to kill itwould be better.
<dael> Rossen: I'm in favor of mostly everything you proposed.
<zcorpan> https://html.spec.whatwg.org/#align-descendants is the magic explained in html
<dael> fantasai: Reason to keep it would be i f we want to standardize. Alternative would be add yet another property to control magic.
<dael> fantasai: We can't unimplement center tag.
<dael> TabAtkins: Benefit of another alignment property is we can make it actually inherit. It might be better structurally.
<dael> fantasai: But then you have a weird thing where you have to figure out, I inheritied this, alignment is this, what wins?
<dael> fantasai: We can't resolve with cascade.
<dael> fantasai: Incorperating it has the benefit that the cascade is understandable.
<dbaron> For what it's worth, I'd probably have an opinion on this if I had ten minutes to think about it...
<dael> TabAtkins: There' definitely problems either way, I agree.
<dael> fantasai: I'm happy to defer
<dael> Rossen: reoslve on rename
<dael> Rossen: Any objections on renaming auto to legacy?
<dael> RESOLVED: rename auto to legacy.
<dael> Rossen: Was that the only hting keeping us from CR on alignment?
<dael> fantasai: Yes...I think we should add legacy to at-risk list. All the issues are closed. I would like to initiate transition.
<dael> Rossen: That would be great.
<dael> fantasai: While we process that we can look at dropping. If it's at-risk we can drop later.
<dael> dbaron: I'll try and start asking this: Is there someone other then the editor that has read the draft and thinks it's ready?
<dael> fantasai: We've had a lot of comments from Igalia & Matt. There have been detailed reviews of the draft. I think it has been impl...this was the reference spec of grid. I think it's gotten decent amount of review.
<dael> dbaron: There's bunches not related to grid and I worry those aren't ready.
<dael> fantasai: I think they're striaght forward. We kept asking for review and no one has so TabAtkins and I have done two line by line reviews of the spec.
<dael> fantasai: If someone wants to review the spec I'm happy to delay 2 weeks, but if it'll be more no response and no review it's not useful.
<dael> fantasai: I've been asking for review for years.
<dael> dbaron: I submitted comments a year or two ago.
<dael> dbaron: I wouldlike the bar for CR to involve someone other then the editors say they think it's ready.
<dael> fantasai: I totally agree with that.
<astearns> we're meant to show wide review before CR
<dael> dbaron: I can prob look, but not this week.
<rachelandrew> Does this review need to be from an Implementor? I've spent a lot of time reading it, I'd be happy to do a more formal review.
<dael> Rossen: I agree dbaron. We can action the WG to review Alignment spec in the following two weeks. I also sympathize with fantasai saying she has asked for review. Let's use the resolution forcing function. Would you agree two weeks is enough before we call for resolution? Or three?
<dael> dbaron: 2 is fine.
<astearns> rachelandrew: does not have to be from an implementor - your formal review would be great
<fantasai> gsnedders, we don't want to advance specs to CR that nobody cares about
<dael> Rossen: prop: Move CSS Alignment to CR with the added legacy value defined as at-risk. The action of starting the CR process will start in 2 weeks unless we heard elsewise.
<fantasai> gsnedders, that's a recipe for bad news
<dael> Florian: Have we asked for horizontal review? We could bundle the two.
<dael> Rossen: Let's see. Who do we need for horizontal review? a11y folks.
<rachelandrew> ok, I have some very long airplane flights in the next 2 weeks :D
<dael> ChrisL: i18n, privacy, security
<dael> fantasai: I think for privacy & security we should send them a note saying we don't think there's anything that would effect you, but feel free to read the spec.
<dael> Rossen: That's good.
<dael> Florian: Is 2 weeks short for horizontal?
<dael> ChrisL: It is. i18n watnts 4 weeks.
<dael> ChrisL: I think for psecs we're prepping for CR we should in the future schedule earlier.
<dael> fantasai: I don't think we'll g et feedback on horizontal review. Maybe generalthis could b e better written.
<dael> fantasai: i18n wanted flow relative directions which is what we did. We have self-start vs start so there's all kinds of writing mode control. a11y issues are ones that effect everything.
<dael> Rossen: I think we should stick to 2 weeks. IF someone starts screaming we can be flexible.
<dael> RESOLVED: Move CSS Alignment to CR with the added legacy value defined as at-risk. The action of starting the CR process will start in 2 weeks (May 27) unless we heard elsewise.
<fantasai> s/everything/everyone, e.g. if stuff overflows it could be bad/
@atanassov

This comment has been minimized.

Collaborator

atanassov commented May 10, 2017

CSSWG Resolution: Publish a new WD of the draft

@MatsPalmgren

This comment has been minimized.

MatsPalmgren commented May 16, 2017

FYI, the "Computed value" description also needs to be updated, it currently says:

specified value, except for auto (see prose)

https://drafts.csswg.org/css-align/#justify-items-property

BTW, have you considered restricting the order of the legacy keyword? It seems a bit odd now that <overflow-position>? <self-position> has an order that legacy does not. (I don't mind, I just want to make sure you intentionally want to continue allowing both legacy left and left legacy etc).

@MatsPalmgren

This comment has been minimized.

MatsPalmgren commented May 16, 2017

Fwiw, I just implemented this and I noted that place-items: center legacy (etc) is now a valid value. There's no ambiguity (it specifies align-items:center; justify-items:legacy), but since center legacy is also a valid justify-items value it might look a bit confusing at first. Not sure whether only allowing legacy center in justify-items would help much though... (also depends on the outcome of issue #1002)

@fantasai

This comment has been minimized.

Contributor

fantasai commented Jun 21, 2017

@MatsPalmgren Fixed the Computed value line. Wrt fixing the order... we try not to fix the order of values unless there's a parsing ambiguity, and as you point out here, there isn't. So unless you think it might be a problem in the future, let's leave it unfixed. :)

Wrt allowing legacy in place-items, the current set of edits leave it out, but there's an open discussion in #1449 on that topic; if you have an opinion either way please let us know. :)

@tabatkins tabatkins closed this Jun 21, 2017

@MatsPalmgren

This comment has been minimized.

MatsPalmgren commented Jun 21, 2017

My opinion on this issue, and issue #1449, depends on the outcome of issue #1002.
If we adopt slash as the separator (between block/inline-axis values), then I see no problem in supporting the full set of values. If we continue to use space, then there will be severe ambiguities with fallback values in shorthands. If we're going to change the syntax for these shorthands from using space to slash then I think that needs to happen now if it's going to happen at all.

MXEBot pushed a commit to mirror/chromium that referenced this issue Jan 30, 2018

[css-align] Add use counter for the 'legacy' alignment
The CSS WG resolved in May 2017 to replace the 'auto' keyword by
'legacy' in the CSS syntax of the justify-items property.

w3c/csswg-drafts#1318

According to the spec, the 'auto' (now 'legacy') value applied to the
justify-items property should be resolved, during the style resolution
phase before layout, with its inherited value if this includes the
'legacy' keyword (plus 'left', 'right', or 'center').

There is no behavior change in the affected property due to this syntax
change.

Since 'auto' (now 'legacy') is the default value of the justify-items
property, this change has a relative big impact. However, we are only
interested on evaluate the use of the 'legacy' alignment, which has to
be explicitly set in the parent element.

Change-Id: Id2ae6735fb28ac44062aaec79828ce97d7edd5d6
Reviewed-on: https://chromium-review.googlesource.com/886365
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532380}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this issue Feb 6, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this issue Feb 6, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this issue Feb 8, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this issue Feb 9, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

chromium-wpt-export-bot added a commit to web-platform-tests/wpt that referenced this issue Feb 9, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

hubot pushed a commit to WebKit/webkit that referenced this issue Feb 9, 2018

jfernandez@igalia.com
[css-align] Implement the new behavior of 'legacy' for justify-items
https://bugs.webkit.org/show_bug.cgi?id=172712

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:

Source/WebCore:

The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Since the new value 'legacy' is also the default value, I don't expect
this change to break content of sites currently using the 'justify-items'
property.

No new tests, rebaselined existing test.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ItemPosition const):
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAuto):
(WebCore::isNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeJustifyItems):
(WebCore::consumeSimplifiedDefaultPosition):
(WebCore::consumeSimplifiedSelfPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedJustifyItems const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialJustifyItems):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

LayoutTests:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* css3/parse-alignment-of-root-elements.html:
* css3/parse-place-items.html:
* fast/css/parse-justify-items.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@228319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ardalanamini pushed a commit to siliconjs/chromium that referenced this issue Feb 9, 2018

[css-align] justfy-items accepts 'legacy' and drops support for 'auto'
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

bertogg pushed a commit to Igalia/webkit that referenced this issue Mar 6, 2018

carlosgc@webkit.org
Merge r228319 - [css-align] Implement the new behavior of 'legacy' fo…
…r justify-items

https://bugs.webkit.org/show_bug.cgi?id=172712

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:

Source/WebCore:

The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Since the new value 'legacy' is also the default value, I don't expect
this change to break content of sites currently using the 'justify-items'
property.

No new tests, rebaselined existing test.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ItemPosition const):
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAuto):
(WebCore::isNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeJustifyItems):
(WebCore::consumeSimplifiedDefaultPosition):
(WebCore::consumeSimplifiedSelfPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedJustifyItems const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialJustifyItems):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

LayoutTests:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* css3/parse-alignment-of-root-elements.html:
* css3/parse-place-items.html:
* fast/css/parse-justify-items.html:

git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.20@228681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 7, 2018

Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy'…
… and drops support for 'auto', a=testonly

Automatic update from web-platform-tests
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f
wpt-pr: 9400
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

mykmelez pushed a commit to mozilla/gecko that referenced this issue Mar 8, 2018

Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy'…
… and drops support for 'auto', a=testonly

Automatic update from web-platform-tests
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f
wpt-pr: 9400
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 9, 2018

Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy'…
… and drops support for 'auto', a=testonly

Automatic update from web-platform-tests
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f
wpt-pr: 9400
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

mykmelez pushed a commit to mozilla/gecko that referenced this issue Mar 12, 2018

Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy'…
… and drops support for 'auto', a=testonly

Automatic update from web-platform-tests
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Link to the intent-to-ship-and-remove request:

https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer

Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535593}

<!-- Reviewable:start -->

<!-- Reviewable:end -->

wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f
wpt-pr: 9400
reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead

ashkulz pushed a commit to ashkulz/webkit that referenced this issue Apr 13, 2018

carlosgc@webkit.org
Merge r228319 - [css-align] Implement the new behavior of 'legacy' fo…
…r justify-items

https://bugs.webkit.org/show_bug.cgi?id=172712

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:

Source/WebCore:

The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

w3c/csswg-drafts#1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Since the new value 'legacy' is also the default value, I don't expect
this change to break content of sites currently using the 'justify-items'
property.

No new tests, rebaselined existing test.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ItemPosition const):
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAuto):
(WebCore::isNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeJustifyItems):
(WebCore::consumeSimplifiedDefaultPosition):
(WebCore::consumeSimplifiedSelfPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedJustifyItems const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialJustifyItems):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

LayoutTests:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* css3/parse-alignment-of-root-elements.html:
* css3/parse-place-items.html:
* fast/css/parse-justify-items.html:

git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.20@228681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

robin-raymond pushed a commit to webrtc-uwp/zzz-obsolete.chromium-tools that referenced this issue Sep 20, 2018

[css-align] Add use counter for the 'legacy' alignment
The CSS WG resolved in May 2017 to replace the 'auto' keyword by
'legacy' in the CSS syntax of the justify-items property.

w3c/csswg-drafts#1318

According to the spec, the 'auto' (now 'legacy') value applied to the
justify-items property should be resolved, during the style resolution
phase before layout, with its inherited value if this includes the
'legacy' keyword (plus 'left', 'right', or 'center').

There is no behavior change in the affected property due to this syntax
change.

Since 'auto' (now 'legacy') is the default value of the justify-items
property, this change has a relative big impact. However, we are only
interested on evaluate the use of the 'legacy' alignment, which has to
be explicitly set in the parent element.

Change-Id: Id2ae6735fb28ac44062aaec79828ce97d7edd5d6
Reviewed-on: https://chromium-review.googlesource.com/886365
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Original-Commit-Position: refs/heads/master@{#532380}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1fe575dbeb077ce496b11c05bd92aed93289831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment