New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox][css-grid] Floor outer sizes at zero where needed #2655

Closed
fantasai opened this Issue May 8, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@fantasai
Contributor

fantasai commented May 8, 2018

There are a number of places where we use the outer size (margin-box size) of a box in layout calculations, e.g. in Flexbox and Grid Layout. We should make sure that we're flooring it at zero in the places where it needs to be floored (and not in the places where it needs to be not floored).

@fantasai fantasai changed the title from [css-flexbox][css-grid] Floor outer size at zero to [css-flexbox][css-grid] Floor outer sizes at zero where needed May 8, 2018

@tabatkins

This comment has been minimized.

Member

tabatkins commented Aug 24, 2018

@fantasai and I independently reviewed Flexbox, and think all the outer references are either clamped appropriately or don't need to be clamped (and added a note about it not being clamped in one spot), so I'm removing the flexbox tag.

@fantasai

This comment has been minimized.

Contributor

fantasai commented Oct 10, 2018

Ran an audit over grid wrt inner vs outer sizes also.

@fantasai fantasai added css-grid-1 and removed css-flexbox-1 labels Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment