Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox][css-grid] Floor outer sizes at zero where needed #2655

Closed
fantasai opened this issue May 8, 2018 · 2 comments
Closed

[css-flexbox][css-grid] Floor outer sizes at zero where needed #2655

fantasai opened this issue May 8, 2018 · 2 comments

Comments

@fantasai
Copy link
Collaborator

fantasai commented May 8, 2018

There are a number of places where we use the outer size (margin-box size) of a box in layout calculations, e.g. in Flexbox and Grid Layout. We should make sure that we're flooring it at zero in the places where it needs to be floored (and not in the places where it needs to be not floored).

@fantasai fantasai changed the title [css-flexbox][css-grid] Floor outer size at zero [css-flexbox][css-grid] Floor outer sizes at zero where needed May 8, 2018
@tabatkins
Copy link
Member

@fantasai and I independently reviewed Flexbox, and think all the outer references are either clamped appropriately or don't need to be clamped (and added a note about it not being clamped in one spot), so I'm removing the flexbox tag.

@fantasai
Copy link
Collaborator Author

Ran an audit over grid wrt inner vs outer sizes also.

@fantasai fantasai added css-grid-1 and removed css-flexbox-1 Current Work labels Oct 10, 2018
@fantasai fantasai added this to the css-grid-1 CR 2017-12-14+ milestone Jan 23, 2019
@fantasai fantasai added the Tested Memory aid - issue has WPT tests label Jul 6, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 10, 2020
…e, a=testonly

Automatic update from web-platform-tests
[css-grid] Check inner vs. outer size for percentage computation. w3c/csswg-drafts#2655 (#24476)

--

wpt-commits: 4b5101fabe653a57921f6e7add9ff768027206fa
wpt-pr: 24476
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jul 10, 2020
…e, a=testonly

Automatic update from web-platform-tests
[css-grid] Check inner vs. outer size for percentage computation. w3c/csswg-drafts#2655 (#24476)

--

wpt-commits: 4b5101fabe653a57921f6e7add9ff768027206fa
wpt-pr: 24476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants