Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Rename "min-size contribution" #3277

Closed
tabatkins opened this issue Nov 2, 2018 · 1 comment
Closed

[css-grid] Rename "min-size contribution" #3277

tabatkins opened this issue Nov 2, 2018 · 1 comment

Comments

@tabatkins
Copy link
Member

The term "min-size contribution" is confusingly similar to "min-content contribution". The two terms are also close in meaning, but quite distinct in details, making the whole thing more confusing. We should come up with a better, more distinct name.

The current name was chosen because it's the contribution you get from paying attention to the min-width/height property (aka "min-size" property) rather than width/height like min-content contribution uses. It also reflects the interesting interaction that min-width:auto has with fixed grid tracks, where the size gets clamped to the sum of the track sizes it spans.

@fantasai suggests "minimum contribution"; it's still a "contribution" in spirit, as it's largely calculated the same way as the other contributions. But the term "minimum" is grammatically distinct from "min-content", in a way that "min-size" isn't.

I think that's an improvement, but I'm not sure it's good enough yet to be worth the change. Need some thought on this.

@fantasai
Copy link
Collaborator

Made the switch. Reopen with suggestion if you want something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants