Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] max<min comparison in minmax() #3567

Closed
Loirooriol opened this issue Jan 29, 2019 · 4 comments
Closed

[css-grid] max<min comparison in minmax() #3567

Loirooriol opened this issue Jan 29, 2019 · 4 comments
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1

Comments

@Loirooriol
Copy link
Contributor

From https://drafts.csswg.org/css-grid/#valdef-grid-template-columns-minmax

  • minmax(min, max)
    Defines a size range greater than or equal to min and less than or equal to max. If max < min, then max is ignored and minmax(min,max) is treated as min.

It's not clear whether the last sentence means that minmax(min,max) should be treated as min before starting the sizing algorithm, i.e. that both the initial min and max track sizing functions should be min, or whether it refers to

In all cases, if the growth limit is less than the base size, increase the growth limit to match the base size.

which keeps appearing along the algorithm, and the initial min and max track sizing functions will still be the specified values.

In the former case, please define how to perform the comparison if min and max are not both <length> or resolveable <percentage>.

@fantasai
Copy link
Collaborator

It's the latter. The point of the descriptions up front is so that we know what we're trying to do. Putting the entire algorithm into the description of each value of the property isn't workable.

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Jan 29, 2019

That's what I assumed, but the text is normative so it's confusing. I suggest moving it into a note, and maybe using "will" instead of "is" to hint it will be defined in detail later.

@fantasai
Copy link
Collaborator

OK, tweaked the wording. LMK if it looks OK now.

@Loirooriol
Copy link
Contributor Author

Still doesn't seem 100% clear to me, but now it's better, thanks.

@fantasai fantasai added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted as Editorial Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-grid-1
Projects
None yet
Development

No branches or pull requests

2 participants