-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resize-observer] the spec text on explanatory "ResizeObservation" interface (not intended as a real interface) gets picked up by Reffy tool and baked into WPT tests #3839
Comments
Also, worth stating for the record -- both Chrome 76 and Firefox Nightly 68 correctly "fail" all of the ResizeObservation subtests right now, as shown on wpt.fyi. (only mentioning those two because other engines don't implement ResizeObserver at all.) So, all implementations are correct here, and we just need a spec-fix (which will then implicitly fix the test, since the test is generated by the spec). |
@dholbert I asked on the testing IRC channel, but I'll ask here too. I have no knowledge of the Reffy tool, so how do I change the spec to make it so that it isn't using this example IDL as actual IDL? |
I'm afraid I have no knowledge of the Reffy tool either. (I only figured out that it was involved via following the trail of clues to figure out where the test data was coming from.) |
ResizeObserver is in the latest webkit tech previews too |
ok calling in the big guns - @gsnedders any ideas? |
Reffy extracts the IDL index at the end of the spec. That index contains By the way, I do not know what you're trying to achieve here with |
Fix invalid WebIDL by changing sequence to FrozenArray for lastReportedSizes in the ResizeObservation interface. Currently there are still normative references to this non-normative interface, discussed in #3839. These will be addressed in a follow-up.
Fix invalid WebIDL by changing sequence to FrozenArray for lastReportedSizes in the ResizeObservation interface. Currently there are still normative references to this non-normative interface, discussed in w3c#3839. These will be addressed in a follow-up.
https://wpt.fyi/results/resize-observer/idlharness.window.html shows a bunch of cross-browser test failures for the
ResizeObservation interface
, which come from chunk of IDL:https://github.com/web-platform-tests/wpt/blob/a8d97c0c7c58cdc2def51573e30c2cad92923d75/interfaces/resize-observer.idl#L39-L43
This interface is mentioned in the spec, but it's clearly labeled as an "example" which is not supposed to be exposed to JS:
https://drafts.csswg.org/resize-observer/#resize-observation-interface
Unfortunately, the WPT
interfaces/resize-observer.idl
file is autogenerated, so we can't just edit it to remove this example interface. It'll just come back whenever the file gets regenerated, presumably. So I think we need to edit the spec to make it clearer (to the Reffy tool) that this interface is non-normative and not something that should be tested. (And really, someone should probably add a WPT test to validate that the interface does not exist, since it's not supposed to.)The text was updated successfully, but these errors were encountered: