-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-flexbox] Should clarify if aspect ratio calculations use border-box or content-box #5246
Comments
(however, the inner is probably correct for replaced elements with an intrinsic aspect ratio, which probably (?) shouldn't use box-sizing) cc @fantasai |
…atio calculation, so 'aspect-ratio' text can apply instead. #5246
@cbiesinger Checked in edits to remove the explicit mention of "inner". Do you think this is acceptable to close now? |
Thanks, that helps. I think it would be nice if there was a link to someplace that explicitly defines which box-sizing to use though. |
@cbiesinger I think at some point when the aspect ratio spec and related terminology is more stable, we'll end up adding a lot of cross-links across all our layout specs, but at this point if I add a note pointing to sizing-4 here, I have to add one everywhere else in the spec that mentions “aspect ratio” and I think that's too many notes... If you're implementing |
E.g. here:
https://drafts.csswg.org/css-flexbox/#min-size-auto
The transferred size uses the aspect ratio, but it's not clear whether it should use the content box or border box for the calculation.
Also, here:
https://drafts.csswg.org/css-flexbox/#algo-main-item
the calculation says explicitly that the inner cross size is used, which contradicts https://drafts.csswg.org/css-sizing-4/#valdef-aspect-ratio-ratio which says that box-sizing determines whether to use content-box or border-box
The text was updated successfully, but these errors were encountered: