Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official spec links to non-official w3c.github.io #8798

Closed
Loirooriol opened this issue May 5, 2023 · 7 comments
Closed

Official spec links to non-official w3c.github.io #8798

Loirooriol opened this issue May 5, 2023 · 7 comments

Comments

@Loirooriol
Copy link
Contributor

AFAIK the w3c.github.io mirror is not official.
So why does the official https://drafts.csswg.org/css-backgrounds-3/#border-width have a link to https://w3c.github.io/csswg-drafts/css-values-4/#snap-a-length-as-a-border-width instead of https://drafts.csswg.org/css-values-4/#snap-a-length-as-a-border-width ?

Not sure if this is specific of css-backgrounds or if other specs are affected too.

@LeaVerou
Copy link
Member

LeaVerou commented May 5, 2023

I wonder if we should try to avoid absolute links all together, and instead prefer relative ones (either /css-values-4/@snap-a-length-as-a-border-width or ../css-values-4/@snap-a-length-as-a-border-width)

@dbaron
Copy link
Member

dbaron commented May 5, 2023

I don't see how you can construct a relative cross-spec link that works across all of the base URLs:

@tabatkins
Copy link
Member

The "snapped as a border width" is an autolink, so the URL is coming from the Reffy db. However, I just did a bikeshed update, and get:

╰╴bikeshed refs --text="snap as a border width"
text:      snap as a border width
type:      dfn
spec:      css-values-4
shortname: css-values
level:     4
status:    current
url:       https://drafts.csswg.org/css-values-4/#snap-a-length-as-a-border-width
export:    True
normative: True
for_:      []
==========
text:      snap as a border width
type:      dfn
spec:      css-values-4
shortname: css-values
level:     4
status:    snapshot
url:       https://www.w3.org/TR/css-values-4/#snap-a-length-as-a-border-width
export:    True
normative: True
for_:      []

So the db looks good. And there's nothing locally overriding that either. And I don't see these URLs ever appearing in https://github.com/w3c/webref/commits/main/ed/dfns/css-values-4.json. So I have absolutely no idea how it's showing that URL.

There's a search-and-replace on the github mirror CI that changes links from drafts.csswg.org to csswg-drafts.github.io, but that obviously shouldn't affect anything built by the drafts server.

@plinss
Copy link
Member

plinss commented May 5, 2023

There's a search-and-replace on the github mirror CI that changes links from drafts.csswg.org to csswg-drafts.github.io, but that obviously shouldn't affect anything built by the drafts server.

The draft server is currently proxying the github mirror for the actual drafts, so it's not serving anything it builds itself.

I recommend the search and replace on the github CI be removed. Nothing should be using public facing csswg-drafts.github.io links anymore.

@tabatkins
Copy link
Member

Oh, I didn't realize that had been completed! Okay, yeah, I can make the change. I'll add in the script to auto-redirect if you visit the github.io site, too.

tabatkins added a commit that referenced this issue May 5, 2023
@tabatkins
Copy link
Member

And done. The CI build no longer replaces links, and it automatically inserts a redirect script that detects if the url is on github.io, redirecting to the drafts server. The root page also redirects to the drafts server listing.

Hm, I just realized that all the redirects that caught the unversioned links are broken now, tho. I'll restore them.

@tabatkins
Copy link
Member

Actually, ehhhhh, it'd be a bunch of trouble. I won't bother unless there's an obvious need.

sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 6, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 6, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
robinlinden added a commit to robinlinden/hastur that referenced this issue May 6, 2023
tidoust added a commit to w3c/browser-specs that referenced this issue May 9, 2023
The `https://w3c.github.io/csswg-drafts/` URLs now redirect to
`https://drafts.csswg.org/css-viewport/`, following:
w3c/csswg-drafts#8798

Using `w3c.github.io` URLs no longer makes sense as a result. On top of adding
a redirection, it prevents build because the w3c.github.io URL for `css-page-4`
is currently broken.
tidoust added a commit to w3c/browser-specs that referenced this issue May 9, 2023
The `https://w3c.github.io/csswg-drafts/` URLs now redirect to
`https://drafts.csswg.org/css-viewport/`, following:
w3c/csswg-drafts#8798

Using `w3c.github.io` URLs no longer makes sense as a result. On top of adding
a redirection, it prevents build because the w3c.github.io URL for `css-page-4`
is currently broken.
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 10, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 11, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 11, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 13, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 15, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 16, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 16, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 16, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 18, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 18, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 18, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 18, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
sideshowbarker added a commit to mdn/browser-compat-data that referenced this issue May 18, 2023
Apparently all of the w3c.github.io/csswg-drafts URLs are now 404 due to
a change made in w3c/csswg-drafts#8798 that leaves
the community with no choice but to use the drafts.csswg.org URLs again.

Relates to mdn/content#26613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants