-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-values-4][cssom] Serialization of <position> #8996
Comments
https://wiki.csswg.org/ideas/mistakes
I guess that a reasonable expectation would be that See whatwg/compat#28 and #7802. |
The citations you linked is for |
Oh I mixed them up in my mind, sorry. But it's still the case that |
Yes, |
|
Ah, I forgot about that when I approved the test change that reduced some position serializations. We should capture that in the spec, since it's important. |
…ation violates the shortest-serialization-principle. #8996
https://bugs.webkit.org/show_bug.cgi?id=258585 rdar://111750372 Reviewed by Oriol Brufau and Simon Fraser. This was clarified in w3c/csswg-drafts#8996 It's ambiguous in some cases, especially when followed by length. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: * LayoutTests/fast/css/background-position-serialize-expected.txt: * LayoutTests/fast/css/background-position-serialize.html: * LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: * LayoutTests/fast/masking/parsing-webkit-mask.html: * LayoutTests/fast/masking/parsing-mask-expected.txt: * LayoutTests/fast/masking/parsing-mask.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-anchor-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt: * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeLayered const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePosition): Canonical link: https://commits.webkit.org/268291@main
https://drafts.csswg.org/css-values-4/#position-serialization says:
but https://drafts.csswg.org/cssom/#serializing-css-values says:
Which one is right? Personally I have a slight preference of omitting redundant values, unless there's a specific compat reason not to (which is mandated by the CSSOM spec), just for the sake of consistency with serialization of other types.
The text was updated successfully, but these errors were encountered: