-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS <position> should never serialize to a single value #18043
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
nt1m:eng/CSS-position-should-never-serialize-to-a-single-value
Sep 22, 2023
Merged
CSS <position> should never serialize to a single value #18043
webkit-commit-queue
merged 1 commit into
WebKit:main
from
nt1m:eng/CSS-position-should-never-serialize-to-a-single-value
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 5ee7fb4) |
smfr
approved these changes
Sep 21, 2023
Loirooriol
approved these changes
Sep 21, 2023
at 50% 50%
in basic shapes
EWS run on previous version of this PR (hash 91bc7bf)
|
at 50% 50%
in basic shapes91bc7bf
to
c647e70
Compare
EWS run on current version of this PR (hash c647e70)
|
https://bugs.webkit.org/show_bug.cgi?id=258585 rdar://111750372 Reviewed by Oriol Brufau and Simon Fraser. This was clarified in w3c/csswg-drafts#8996 It's ambiguous in some cases, especially when followed by length. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: * LayoutTests/fast/css/background-position-serialize-expected.txt: * LayoutTests/fast/css/background-position-serialize.html: * LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: * LayoutTests/fast/masking/parsing-webkit-mask.html: * LayoutTests/fast/masking/parsing-mask-expected.txt: * LayoutTests/fast/masking/parsing-mask.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-anchor-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt: * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeLayered const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePosition): Canonical link: https://commits.webkit.org/268291@main
c647e70
to
860ac0e
Compare
Committed 268291@main (860ac0e): https://commits.webkit.org/268291@main Reviewed commits have been landed. Closing PR #18043 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
860ac0e
c647e70
🛠 wincairo🧪 wpe-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🛠 watch-sim