CSS <position> should never serialize to a single value #18043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 5ee7fb4) |
nt1m
requested review from
darinadler,
smfr,
Loirooriol,
anttijk and
heycam
smfr
approved these changes
Sep 21, 2023
nt1m
added
merge-queue
webkit-ews-buildbot
added
the
merging-blocked
Loirooriol
approved these changes
Sep 21, 2023
nt1m
changed the title
at 50% 50% in basic shapes
|
EWS run on previous version of this PR (hash 91bc7bf)
|
nt1m
changed the title
at 50% 50% in basic shapes
nt1m
force-pushed
the
eng/CSS-position-should-never-serialize-to-a-single-value
branch
from
91bc7bf
to
c647e70
Compare
|
EWS run on current version of this PR (hash c647e70)
|
https://bugs.webkit.org/show_bug.cgi?id=258585 rdar://111750372 Reviewed by Oriol Brufau and Simon Fraser. This was clarified in w3c/csswg-drafts#8996 It's ambiguous in some cases, especially when followed by length. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: * LayoutTests/fast/css/background-position-serialize-expected.txt: * LayoutTests/fast/css/background-position-serialize.html: * LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: * LayoutTests/fast/masking/parsing-webkit-mask.html: * LayoutTests/fast/masking/parsing-mask-expected.txt: * LayoutTests/fast/masking/parsing-mask.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-anchor-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt: * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeLayered const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePosition): Canonical link: https://commits.webkit.org/268291@main
webkit-commit-queue
force-pushed
the
eng/CSS-position-should-never-serialize-to-a-single-value
branch
from
c647e70
to
860ac0e
Compare
|
Committed 268291@main (860ac0e): https://commits.webkit.org/268291@main Reviewed commits have been landed. Closing PR #18043 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nt1m
deleted the
eng/CSS-position-should-never-serialize-to-a-single-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
860ac0e
c647e70
🛠 wincairo🧪 wpe-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🛠 watch-sim