Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom][css-grid][css-transforms] Make 'transform-origin' and 'perspe… #1019

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 10, 2017

…ctive-origin' resolved value like 'height'

Fixes #392.

…ctive-origin' resolved value like 'height'

Fixes #392.
@mrego
Copy link
Member

mrego commented Feb 15, 2017

Just one question, shouldn't grid-row-gap and grid-column-gap be marked too?
https://drafts.csswg.org/css-grid/#propdef-grid-column-gap

And one nit, the commit says css-grid but doesn't talk about grid properties. Probably it'd be nice to update the commit title and description.

@zcorpan
Copy link
Member Author

zcorpan commented Feb 15, 2017

Just one question, shouldn't grid-row-gap and grid-column-gap be marked too?
https://drafts.csswg.org/css-grid/#propdef-grid-column-gap

No, the spec for those doesn't say anything about "resolved value", so they work like normal properties. (If implementations disagree, please file a new issue.)

And one nit, the commit says css-grid but doesn't talk about grid properties. Probably it'd be nice to update the commit title and description.

OK, yeah.

Thanks!

@zcorpan
Copy link
Member Author

zcorpan commented Feb 15, 2017

Proposed commit message when merging

[cssom][css-grid][css-transforms] Make 'transform-origin' and 'perspective-origin' resolved value like 'height'

Also mention that 'grid-template-rows' and 'grid-template-columns'
are resolved value special case properties (no normative change).

Fixes #392.

@mrego
Copy link
Member

mrego commented Feb 15, 2017

Just one question, shouldn't grid-row-gap and grid-column-gap be marked too?
https://drafts.csswg.org/css-grid/#propdef-grid-column-gap

No, the spec for those doesn't say anything about "resolved value", so they work like normal properties. (If implementations disagree, please file a new issue.)

Yes sorry for the noise, I was mixing in my mind again computed vs resolved value.

@fantasai
Copy link
Collaborator

fantasai commented Mar 8, 2017

Looks OK to me.

@zcorpan zcorpan merged commit 2317722 into master Mar 9, 2017
@zcorpan zcorpan deleted the zcorpan/resolved-value-like-height branch March 9, 2017 12:20
@syncbot syncbot restored the zcorpan/resolved-value-like-height branch March 13, 2017 22:11
@plinss plinss deleted the zcorpan/resolved-value-like-height branch August 2, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cssom][css-transforms] Conflicting on resolved value of various properties
3 participants