[cssom-view] add shadowRoots parameter to caretPositionFromPoint API.
#10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per w3c#9932, add `shadowRoots` parameter to `caretPositionFromPoint` API.
siliu1
changed the title
shadowRoots parameter to caretPositionFromPoint API.
dandclark
reviewed
Apr 16, 2024
Bubble `caret range` out of the shadow roots.
dandclark
reviewed
Apr 16, 2024
dandclark
approved these changes
Apr 16, 2024
Address PR comments.
|
nit: Could you add links to all the implementation bugs in the PR description? |
sanketj
requested changes
Apr 18, 2024
Address PR comment.
Could you also add the link for the WebKit implementation bug? If one doesn't exist, we should file one. |
sanketj
requested changes
Apr 18, 2024
Added WebKit implementation bug for the API. |
Address PR comment.
sanketj
requested changes
Apr 19, 2024
linked created issue(10230) to the spec.
sanketj
approved these changes
Apr 19, 2024
This was referenced Apr 25, 2024
|
As far as I can tell this works like in https://w3c.github.io/selection-api/#dom-selection-getcomposedranges as @mfreed7 suggested in #9932 (comment) and per the CSSWG resolution. cc @emilio |
zcorpan
approved these changes
May 3, 2024
emilio
reviewed
May 7, 2024
| @@ -1148,6 +1145,8 @@ aborting on the first step that returns a value: | |||
|
|
|||
| Note: This {{DOMRect}} object is not <a spec=html>live</a>. | |||
|
|
|||
| Issue(10230): Consider removing <a>caret range</a> concept from <dfn>caret position</dfn> interface. | |||
There was a problem hiding this comment.
This introduces a build error fwiw. caret position is defined twice.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 3, 2024
…M behavior r=webidl,smaug,emilio Spec - https://drafts.csswg.org/cssom-view/Overview#dom-document-caretpositionfrompoint Spec PR - w3c/csswg-drafts#10200 TAG Review - w3ctag/design-reviews#949 Differential Revision: https://phabricator.services.mozilla.com/D215184
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 3, 2024
…M behavior r=webidl,smaug,emilio Spec - https://drafts.csswg.org/cssom-view/Overview#dom-document-caretpositionfrompoint Spec PR - w3c/csswg-drafts#10200 TAG Review - w3ctag/design-reviews#949 Differential Revision: https://phabricator.services.mozilla.com/D215184
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 7, 2024
…M behavior r=webidl,smaug,emilio Spec - https://drafts.csswg.org/cssom-view/Overview#dom-document-caretpositionfrompoint Spec PR - w3c/csswg-drafts#10200 TAG Review - w3ctag/design-reviews#949 Differential Revision: https://phabricator.services.mozilla.com/D215184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #9932, add
shadowRootsparameter tocaretPositionFromPointAPI.Implementation bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1889503
https://issues.chromium.org/issues/332774620
https://bugs.webkit.org/show_bug.cgi?id=172137
WPT test coverage will be added subsequently.