New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-shadow-parts] rephrase to make it clear which shadow root #2467
Conversation
b836957
to
cc635be
Compare
cc635be
to
5f9d66e
Compare
pr-preview of this is here it's against my own repo since pr-preview doesn't currently work for w3c/csswg-drafts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also explain why we're adding files to docs/rendered directory? I'm not familiar with it.
@@ -7,7 +7,7 @@ Status: ED | |||
Work Status: exploring | |||
URL: http://drafts.csswg.org/css-shadow-parts/ | |||
Editor: Tab Atkins-Bittner, Google, http://xanthir.com/contact/, w3cid 42199 | |||
Abstract: This specification defines the ''::part()'' and ''::theme()'' pseudo-elements on <a>shadow hosts</a>, allowing <a>shadow hosts</a> to selectively expose chosen elements from their <a>shadow tree</a> to the outside page for styling purposes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we want to take these links out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be happening. I think I took the wrong base for this PR. I will fix that.
When dealing with mappings on host elements there are 2 possible meanings to "shadow root" - the one attached to the host and the one containing the host. In the spec, only one makes sense, so it's unambiguous but this change makes it explicit.