Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-shadow-parts] rephrase to make it clear which shadow root #2467

Closed
wants to merge 10 commits into from
Closed

[css-shadow-parts] rephrase to make it clear which shadow root #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2a80a15
add rendered version
fergald Mar 30, 2018
ff6cfe0
generated from fcbb4a9c72acf628d80722e500f667a7d51d4ba7
fergald Mar 31, 2018
ff45b15
add default.css
fergald Mar 31, 2018
40138ae
reall generated from b66a7c8b73408045835b2c8542a30e60f751f161
fergald Mar 31, 2018
98c263d
move into css-shadow-parts
fergald Mar 31, 2018
e3844ae
move into css-shadow-parts-1
fergald Mar 31, 2018
0e58adf
add pr-preview
fergald Apr 6, 2018
7934e25
fix path
fergald Apr 10, 2018
f815c69
remove <a> from abstract so that we can get previews
fergald May 7, 2018
5f9d66e
rephrase to make it clear which shadow root
fergald Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pr-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"src_file": "css-shadow-parts-1/Overview.bs",
"type": "bikeshed",
"params": {
}
}
8 changes: 4 additions & 4 deletions css-shadow-parts-1/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Status: ED
Work Status: exploring
URL: http://drafts.csswg.org/css-shadow-parts/
Editor: Tab Atkins-Bittner, Google, http://xanthir.com/contact/, w3cid 42199
Abstract: This specification defines the ''::part()'' and ''::theme()'' pseudo-elements on <a>shadow hosts</a>, allowing <a>shadow hosts</a> to selectively expose chosen elements from their <a>shadow tree</a> to the outside page for styling purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we want to take these links out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be happening. I think I took the wrong base for this PR. I will fix that.

Abstract: This specification defines the ''::part()'' and ''::theme()'' pseudo-elements on shadow hosts, allowing shadow hosts to selectively expose chosen elements from their shadow tree to the outside page for styling purposes.
</pre>

<pre class=link-defaults>
Expand Down Expand Up @@ -133,17 +133,17 @@ Each part mapping is one of:

<dl class=switch>
: <code>ident</code>
:: Adds «[ ident → el ]» to the <a>shadow root's</a> <a>shadow part map</a>.
:: Adds «[ ident → el ]» to the <a>shadow part map</a> of the <a>shadow root</a> containing el.

: <code>ident1 => ident2</code>
:: If el is a <a>shadow host</a>,
and it's <a>shadow root's</a> <a>shadow part map</a> |partMap| [=map/contains=] ident1,
then this adds «[ ident2 → |partMap|[ident1] ]» to the <a>shadow root's</a> <a>shadow part map</a>.
then this adds «[ ident2 → |partMap|[ident1] ]» to the <a>shadow part map</a> of the <a>shadow root</a> containing el.

: <code>* => prefix*</code>
:: If el is a <a>shadow host</a>,
then [=map/for each=] |ident| → |subEl| in el's <a>shadow root's</a> <a>shadow part map</a>,
«[ prefix + |ident| → |subEl| ]» is added to the <a>shadow root's</a> <a>shadow part map</a>.
«[ prefix + |ident| → |subEl| ]» is added to the <a>shadow part map</a> of the <a>shadow root</a> containing el.

: anything else
:: Ignored for error-recovery / future compat.
Expand Down