[cssom-view] Add window.screenLeft and window.screenTop as aliases #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that usage of these attributes are high and that they are implemented in Chrome, WebKit, and Edge, standardization seems like the best option for screenLeft and screenTop. Add them into the spec as simple aliases of screenX and screenY. Fixes w3c#1091.
csnardi
changed the title
|
@tabatkins, can you merge if I write tests? |
|
yeah |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2018
Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: #5471
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2018
Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: #5471
|
The tests in web-platform-tests/wpt#13543 have been merged now. @tabatkins, can you merge this? There's an Intent to Implement and Ship: window.screenLeft and window.screenTop aliases on dev-platform. You rock, @emilio! |
ewilligers
approved these changes
Oct 24, 2018
|
Thanks @ewilligers! Who can merge this now? |
|
Changes are usually approved or merged by an editor. However, the editors of CSSOM View are listed in
|
|
Thanks @ewilligers! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 7, 2018
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739 wpt-pr: 13543 --HG-- rename : testing/web-platform/tests/tools/lint/tests/dummy/about_blank.html => testing/web-platform/tests/tools/lint/tests/dummy/ref/about_blank-ref.html
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 7, 2018
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- Update screenLeftTop.html -- Merge pull request #13543 from web-platform-tests/foolip/screenLeftTop Add tests for `screenLeft` and `screenTop` -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739, 9b13cb18deeccf3e1da44e227c343531deffa1fb, 9419b7f7d685502b8c900dbce2500dfdedb0edec wpt-pr: 13543
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 8, 2018
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739 wpt-pr: 13543
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 8, 2018
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- Update screenLeftTop.html -- Merge pull request #13543 from web-platform-tests/foolip/screenLeftTop Add tests for `screenLeft` and `screenTop` -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739, 9b13cb18deeccf3e1da44e227c343531deffa1fb, 9419b7f7d685502b8c900dbce2500dfdedb0edec wpt-pr: 13543
Zirro
added a commit
to Zirro/jsdom
that referenced
this pull request
Jan 3, 2019
These were indeed added to the spec in w3c/csswg-drafts#2669.
domenic
pushed a commit
to jsdom/jsdom
that referenced
this pull request
Jan 14, 2019
These were indeed added to the spec in w3c/csswg-drafts#2669.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739 wpt-pr: 13543 UltraBlame original commit: da737c36261fe578e54d57575510b9258ac68fb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- Update screenLeftTop.html -- Merge pull request #13543 from web-platform-tests/foolip/screenLeftTop Add tests for `screenLeft` and `screenTop` -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739, 9b13cb18deeccf3e1da44e227c343531deffa1fb, 9419b7f7d685502b8c900dbce2500dfdedb0edec wpt-pr: 13543 UltraBlame original commit: ced4e022b06516738488d8b9f1c469661220f5df
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739 wpt-pr: 13543 UltraBlame original commit: da737c36261fe578e54d57575510b9258ac68fb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- Update screenLeftTop.html -- Merge pull request #13543 from web-platform-tests/foolip/screenLeftTop Add tests for `screenLeft` and `screenTop` -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739, 9b13cb18deeccf3e1da44e227c343531deffa1fb, 9419b7f7d685502b8c900dbce2500dfdedb0edec wpt-pr: 13543 UltraBlame original commit: ced4e022b06516738488d8b9f1c469661220f5df
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739 wpt-pr: 13543 UltraBlame original commit: da737c36261fe578e54d57575510b9258ac68fb6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…p`, a=testonly Automatic update from web-platform-testsAdd tests for `screenLeft` and `screenTop` Matches w3c/csswg-drafts#2669. Note that `screenX` and `screenY` themselves aren't tested at all: web-platform-tests/wpt#5471 -- Update screenLeftTop.html -- Merge pull request #13543 from web-platform-tests/foolip/screenLeftTop Add tests for `screenLeft` and `screenTop` -- wpt-commits: 384330eb99484763b94f4a986fa8cacabb579739, 9b13cb18deeccf3e1da44e227c343531deffa1fb, 9419b7f7d685502b8c900dbce2500dfdedb0edec wpt-pr: 13543 UltraBlame original commit: ced4e022b06516738488d8b9f1c469661220f5df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that usage of these attributes are high and that they are implemented in Chrome, WebKit, and Edge, standardization seems like the best option for
screenLeftandscreenTop. Add them into the spec as simple aliases ofscreenXandscreenY.Fixes #1091.