-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-ui] appearance: Remove 'button-bevel' #3942
Conversation
|
I confirmed WebKit had |
Thank you @MatsPalmgren and @tkent-google In my testing, I thought 'listbox' was close enough to 'none' such that it could be an alias. But I've reverted this so that it's an alias to 'auto' again. |
The 'button-bevel' value is removed in Chromium 75: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ldH_uIfk_QE/Ua0bGyLIAwAJ Tests: web-platform-tests/wpt#14980
edb6305
to
06463de
Compare
Browser bugs: Here's a Live DOM Viewer test to check which values (of those removed in Chromium 75) are supported: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me. We do have some buttom-bevel rendering support in Gecko, but if we can live without it I'm ok with this.
If for some reason removing it would break something we may have to revisit this.
Looks good to me. We should be aligning the compat values with the subset of things implemented by browsers that are needed for compat. Values that are being dropped by browsers shouldn't stay in the spec. Merging. |
Thank you, @frivoal! |
…rds are supported, a=testonly Automatic update from web-platform-tests [css-ui] Update which 'appearance' keywords are supported (#14980) Follows w3c/csswg-drafts#3942 -- wp5At-commits: 6e850694b1f2e477075f63b02838645b9e1c2b08 wpt-pr: 14980
…rds are supported, a=testonly Automatic update from web-platform-tests [css-ui] Update which 'appearance' keywords are supported (#14980) Follows w3c/csswg-drafts#3942 -- wp5At-commits: 6e850694b1f2e477075f63b02838645b9e1c2b08 wpt-pr: 14980
…rds are supported, a=testonly Automatic update from web-platform-tests [css-ui] Update which 'appearance' keywords are supported (#14980) Follows w3c/csswg-drafts#3942 -- wp5At-commits: 6e850694b1f2e477075f63b02838645b9e1c2b08 wpt-pr: 14980 UltraBlame original commit: 6f99efd9adf7ac916ec5dd0007ae9b9190363cea
…rds are supported, a=testonly Automatic update from web-platform-tests [css-ui] Update which 'appearance' keywords are supported (#14980) Follows w3c/csswg-drafts#3942 -- wp5At-commits: 6e850694b1f2e477075f63b02838645b9e1c2b08 wpt-pr: 14980 UltraBlame original commit: 6f99efd9adf7ac916ec5dd0007ae9b9190363cea
…rds are supported, a=testonly Automatic update from web-platform-tests [css-ui] Update which 'appearance' keywords are supported (#14980) Follows w3c/csswg-drafts#3942 -- wp5At-commits: 6e850694b1f2e477075f63b02838645b9e1c2b08 wpt-pr: 14980 UltraBlame original commit: 6f99efd9adf7ac916ec5dd0007ae9b9190363cea
The 'button-bevel' value is removed in Chromium 75:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ldH_uIfk_QE/Ua0bGyLIAwAJ
Tests: web-platform-tests/wpt#14980
cc @tkent-google @MatsPalmgren