Remove text-orientation references from css-logical-props #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
changed the title
kojiishi
reviewed
Nov 8, 2016
There was a problem hiding this comment.
r+ w/nit given dbaron's confirmation on #691 but I'm not an owner of this spec. @atanassov @fantasai ?
| @@ -270,7 +270,7 @@ the margin- and offset- block-start/block-end/inline-start/inline-end properties | |||
|
|
|||
| These properties correspond to the 'top', 'bottom', 'left', and 'right' | |||
| properties. The mapping depends on the <em>parent element's</em> | |||
| 'writing-mode', 'direction', and 'text-orientation'. | |||
| 'writing-mode', 'direction'. | |||
There was a problem hiding this comment.
nit: s/, / and / as in other places
Manishearth
force-pushed
the
no-text-orientation
branch
from
fab44f6
to
701ca14
Compare
|
nit fixed |
|
Thanks for the fix. |
SebastianZ
referenced
this pull request
Apr 25, 2017
* Add issue explaining status * Remove some issues * Indicate float/clear uses inline-* prefixes per Tokyo F2F resolution. * Rename offset-* to inset-* (and define shorthand) to avoid conflict with motion module per astearns' suggestion. * Add an introduction and clean up a bit some prose * Add text-orientation to the list of dependencies * Spec mapping for CSSOM APIs per WG resolution (more details in CSSOM) * Change 4-value mapping to put inline-start before inline-end per WG resolution & Grid Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #691)
r? @fantasai @heycam @kojiishi