Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-4] Editorial: adjust to fetch refactor #7355

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jun 14, 2022

See whatwg/fetch#1413

Fetch now reports timing automatically if initiator is passed.

See whatwg/fetch#1413

Fetch now reports timing automatically if initiator is passed.
@noamr noamr changed the title WIP: Editorial: adjust to fetch refactor WIP: [css-values-4] Editorial: adjust to fetch refactor Jun 14, 2022
annevk pushed a commit to whatwg/fetch that referenced this pull request Jun 17, 2022
As long as fetch callers pass in the necessary data through the request concept, they will not have to make additional calls to get timing reported accurately. Note that this does not work if callers want to use useParallelQueue.

Downstream PRs:
* whatwg/html#7722
* whatwg/xhr#347
* w3c/csswg-drafts#7355
* w3c/beacon#75
* w3c/resource-timing#321
* https://github.com/w3c/navigation-timing/pull/1760

Closes #1208 and closes w3c/navigation-timing#131.
@noamr noamr changed the title WIP: [css-values-4] Editorial: adjust to fetch refactor [css-values-4] Editorial: adjust to fetch refactor Jun 17, 2022
@noamr
Copy link
Collaborator Author

noamr commented Jun 17, 2022

@tabatkins this is now final after the fetch PR has been merged. fixes the WIP patch we've merged by mistake a couple of months ago

@tabatkins tabatkins merged commit b507ff6 into w3c:main Jun 17, 2022
@tabatkins
Copy link
Member

Ooooh, very nice. Thanks so much, Noam!

@triple-underscore
Copy link

If sheet’s origin-clean flag is set, set req’s initiator to "css". [CSSOM]

request's initiator can not take value "css".
It seems that "initiator type" is the correct term.

@noamr
Copy link
Collaborator Author

noamr commented Jun 19, 2022

If sheet’s origin-clean flag is set, set req’s initiator to "css". [CSSOM]

request's initiator can not take value "css". It seems that "initiator type" is the correct term.

Oops, you're right. #7386. Sorry for the noise @tabatkins and thanks for catcing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants