Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust resource-timing reporting to fetch refactor #75

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Adjust resource-timing reporting to fetch refactor #75

merged 6 commits into from
Jun 17, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 20, 2022 •
edited by pr-preview bot
Loading

@noamr noamr mentioned this pull request Mar 20, 2022
Merged
yoavweiss
yoavweiss approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.html Show resolved Hide resolved
@noamr noamr changed the title Use controller to conclude Adjust resource-timing reporting to fetch refactor Jun 14, 2022
annevk pushed a commit to whatwg/fetch that referenced this pull request Jun 17, 2022
@noamr
Inline "finalize and report timing"
4c93f89 
As long as fetch callers pass in the necessary data through the request concept, they will not have to make additional calls to get timing reported accurately. Note that this does not work if callers want to use useParallelQueue.

Downstream PRs:
* whatwg/html#7722
* whatwg/xhr#347
* w3c/csswg-drafts#7355
* w3c/beacon#75
* w3c/resource-timing#321
* https://github.com/w3c/navigation-timing/pull/1760

Closes #1208 and closes w3c/navigation-timing#131.
@noamr noamr closed this Jun 17, 2022
@noamr noamr reopened this Jun 17, 2022
@noamr noamr merged commit 2bd4675 into gh-pages Jun 17, 2022
@noamr noamr deleted the fetch-rename branch June 17, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamr @yoavweiss