[css-grid] Add more tests for grid item containing block #1019
Conversation
- track sizes in % - track sizes in fr - track sizes in fr, within absolute positioned grid
Automatic validation checks of commit 2351ca1 passed. |
| @@ -0,0 +1,34 @@ | |||
| <!DOCTYPE html> | |||
| <meta charset="utf-8"> | |||
| <title>CSS Grid Layout Test: Grid item sizing</title> | |||
There was a problem hiding this comment.
Maybe we could change a little bit the title:
"Grid item sizing in a positioned grid container"
|
Thanks for the tests, they look really nice. I just have a few comments on the last one. I'm fine with that test in this folder. It could be also in But it happens with more tests, that are not easy to determine the right folder. For more complex tests, I think we can use the root |
Make sure test fails in browsers that does not support CSS Grid at all. w3c#1019
Automatic validation checks of commit f47ba57 passed. |
|
Is it better now? |
| <body> | ||
| <p>Test passes if there is a filled green square and <strong>no red</strong>.</p> | ||
| <div id="grid"> | ||
| <div id="test-item"> |
There was a problem hiding this comment.
Nit: Maybe call it test-item-overlapping-green.
|
Sorry but I think it's still not 100% right. |
|
@tomalec could you please take a look to my last comments so we can merge the tests? Thanks :) |
Make sure test shows red in browsers that does not support CSS Grid at all. w3c#1019
Automatic validation checks of commit d72c4d2 passed. |
|
Sorry, that it took that long. |
…ts flexible tracks w3c#1019
Automatic validation checks of commit 32b3e1c passed. |
[css-grid] Add more tests for grid item containing block
|
LGTM. @tomalec no worries. Thank you very much! |
Make sure test fails in browsers that does not support CSS Grid at all. w3c/csswg-test#1019 Build from revision f47ba578bf0bb91743b67fc172c1b9a9e6e85297
Make sure test shows red in browsers that does not support CSS Grid at all. w3c/csswg-test#1019 Build from revision d72c4d2b1375171899eb42e3436182e5a7d1dbb5
…ts flexible tracks w3c/csswg-test#1019 Build from revision 32b3e1cafbe27313761cb963d7f60f8a054c5cff
More tests for grid item sizing started at #1012
%frfr, withinabsolutepositioned grid@mrego, I'm not sure whether last one fits here, maybe it should go to tests for flex size calculation, or even for more complex, non-direct-spec tests folder?
I thought, it would be nice to have it, as current Chrome stable failed on it (IE, Firefox, and Canary passes it)