This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Bug 29090 - Fix DOMRect constructor tests #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec changed to make the constructor parameters optional, but the test wasn't updated.
Automatic validation checks of commit 5b8b47e passed. |
|
LGTM |
zcorpan
added a commit
that referenced
this pull request
Aug 27, 2015
Bug 29090 - Fix DOMRect constructor tests
tschneidereit
added a commit
to tschneidereit/csswg-test
that referenced
this pull request
Aug 28, 2015
Follow-up to w3c#834. I overlooked some tests that needed fixing, and extended the coverage a bit.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 28, 2015
Improve implementation of DOMRect and implement DOMRectReadOnly Passes most tests from test-css. The remaining ones should pass once we have w3c/csswg-test#834. r? @Ms2ger <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7415) <!-- Reviewable:end -->
tschneidereit
added a commit
to tschneidereit/csswg-test
that referenced
this pull request
Aug 28, 2015
Follow-up to w3c#834. I overlooked some tests that needed fixing, and extended the coverage a bit.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Aug 30, 2015
Improve implementation of DOMRect and implement DOMRectReadOnly Passes most tests from test-css. The remaining ones should pass once we have w3c/csswg-test#834. r? @Ms2ger <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7415) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Oct 17, 2015
Improve implementation of DOMRect and implement DOMRectReadOnly Passes most tests from test-css. The remaining ones should pass once we have w3c/csswg-test#834. r? @Ms2ger <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7415) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…DOMRectReadOnly (from tschneidereit:dom-rect); r=nox Passes most tests from test-css. The remaining ones should pass once we have w3c/csswg-test#834. r? @Ms2ger Source-Repo: https://github.com/servo/servo Source-Revision: 810d28a2574cd288ddfa5737ade417ea53a4b690
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec changed to make the constructor parameters optional, but the test wasn't updated.