Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Add pass_if_number_5.xht, and use as a ref for applicable tests #935

Merged
merged 1 commit into from Nov 5, 2015

Conversation

gsnedders
Copy link
Contributor

Review on Reviewable

@syncbot
Copy link
Collaborator

syncbot commented Nov 4, 2015

Automatic validation checks of commit 7f7dfd5 passed.

@Ms2ger
Copy link

Ms2ger commented Nov 5, 2015

I don't understand why it doesn't complain about a file merge mismatch.

@Ms2ger
Copy link

Ms2ger commented Nov 5, 2015

Allegedly, putting references in a top-level directory rather than under a specific spec should work; wanna try that?

@gsnedders
Copy link
Contributor Author

@Ms2ger It doesn't complain about a file merge mismatch because the files are byte-for-byte identical. Can certainly move files to the top level, though.

@syncbot
Copy link
Collaborator

syncbot commented Nov 5, 2015

Automatic validation checks of commit 695eb90 passed.

@Ms2ger
Copy link

Ms2ger commented Nov 5, 2015

Assuming everything ends up in the right place in the built test suite, r+, but please squash before landing.

gsnedders added a commit that referenced this pull request Nov 5, 2015
Add pass_if_number_5.xht, and use as a ref for applicable tests
@gsnedders gsnedders merged commit 9c2c3c1 into w3c:master Nov 5, 2015
@syncbot
Copy link
Collaborator

syncbot commented Nov 5, 2015

Automatic validation checks of commit edbe519 passed.

@plinss
Copy link
Member

plinss commented Nov 6, 2015

Right, that's the point of the merge mismatch error. It's perfectly fine to have multiple copies of a support or reference file in different directories using the same name. The build will only output one copy, but if all the input copies aren't identical, you get the merge mismatch error. This is to allow having tests that use simple relative paths, like 'support/filename.png' work both in the source and output directory structures.

@gsnedders gsnedders deleted the reftest_pass_if_number_5 branch November 28, 2015 15:44
@gsnedders gsnedders restored the reftest_pass_if_number_5 branch February 12, 2016 20:54
@gsnedders gsnedders deleted the reftest_pass_if_number_5 branch February 12, 2016 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants