Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csvw:table predicate vs resources annotation vs resources property #460

Closed
JeniT opened this issue Apr 7, 2015 · 7 comments · Fixed by #468
Closed

csvw:table predicate vs resources annotation vs resources property #460

JeniT opened this issue Apr 7, 2015 · 7 comments · Fixed by #468

Comments

@JeniT
Copy link

JeniT commented Apr 7, 2015

In the metadata document, we use a resources property to hold table description objects. In the data model, we use a resources annotation to hold the list of tables within a table group. But in the RDF generated, the name of the predicate is csvw:table and in the JSON generated there's a table property. Is there a reason for using a different name for the predicate or should these be brought into line? Should we standardise on "table(s)" or "resource(s)"? (The term "resources" originates from the data packaging spec.)

@JeniT JeniT changed the title csvw:table predicate vs **resources** annotation vs resources property csvw:table predicate vs resources annotation vs resources property Apr 7, 2015
@6a6d74
Copy link
Contributor

6a6d74 commented Apr 7, 2015

Use of csvw:table in RDF and table in JSON aspires to provide descriptive terms ... resources is a bit ambiguous & there's only one type of resource that can be included (tables!).

(I wasn't aware of the intent to retain the terminology from the data packaging spec)

I wouldn't strongly object to a change ... but consistency is important.

@gkellogg
Copy link
Member

gkellogg commented Apr 7, 2015

Perhaps it would make more sense to change reaourses to table in the TableGroup description.

@iherman
Copy link
Member

iherman commented Apr 8, 2015

I must admit the term "resources" was always a bit strange to me but not sufficiently to really raise an issue around it. But using the term "tables" seems to be a better descriptive term. So I am in favour of changing that (though it will be a bit of a pain to change it in all our examples... but a good screen editor may be our friend).

The only place where we use the term "resource" (in singular) is for a foreign key reference. I believe it is fine to keep it that way. But the fact that we use the (almost) similar term for two very different purposes may be another good argument to change "resources" to "tables".

Ivan

On 07 Apr 2015, at 21:21 , Jeni Tennison notifications@github.com wrote:

In the metadata document, we use a resources property to hold table description objects. In the data model, we use a resources annotation to hold the list of tables within a table group. But in the RDF generated, the name of the predicate is csvw:table and in the JSON generated there's a table property. Is there a reason for using a different name for the predicate or should these be brought into line? Should we standardise on "table(s)" or "resource(s)"? (The term "resources" originates from the data packaging spec.)


Reply to this email directly or view it on GitHub.

@iherman
Copy link
Member

iherman commented Apr 8, 2015

Changes to be done in the documents:

  • resources -> tables
  • title -> titles

(See http://www.w3.org/2015/04/08-csvw-irc#T14-28-24)

@gkellogg
Copy link
Member

gkellogg commented Apr 8, 2015

Also:

  • notes => csvw:note
  • foreignKeys => csvw:foreignKey (not used in csv2*)

iherman added a commit that referenced this issue Apr 8, 2015
Taking care of the diagram part for issue #460
gkellogg added a commit that referenced this issue Apr 8, 2015
@gkellogg gkellogg removed the Editorial label Apr 8, 2015
@gkellogg gkellogg assigned JeniT and unassigned gkellogg Apr 8, 2015
gkellogg added a commit to ruby-rdf/rdf-tabular that referenced this issue Apr 8, 2015
`csvw:notes` becomes `csvw:note`.
(see w3c/csvw#460)
@gkellogg gkellogg reopened this Apr 9, 2015
@gkellogg
Copy link
Member

gkellogg commented Apr 9, 2015

Open for review by @JeniT.

@JeniT
Copy link
Author

JeniT commented Apr 12, 2015

Looks OK; there were a few things missed but I'll include those when I do other editorial changes.

@JeniT JeniT closed this as completed Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants