added source & source number properties #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #32 also removed reference to that issue
|
I see we overlap a bit, as I did something similar on the flight, but haven't yet pushed. To be consistent with naming, I used _sourceRow; I also added _column, and _sourceColumn along with related model concepts. I'll reconcile and complete this. |
|
OK. Do assign yourself to any issues you are working/want to work on so that we can avoid overlap. (I know you couldn't do this on the plane.) |
…added `_column`, `_sourceRow`, and `_sourceColumn` as other variables available when expanding a `URI template property`. This partially addresses issue #16.
|
Will do, for some reason, I associated this with issue #16 erroneously. |
gkellogg
added a commit
that referenced
this pull request
Feb 15, 2015
added source & source number properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #32
Though note I've also added a
sourceproperty onto table; should this be calledurlinstead, for consistency with the metadata spec?