changed line terminator to be an array #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support the ‘best practice CSV’ which allows either CRLF or LF line terminators.
|
I'll need to update the namespace too. |
…tors`. Still requires @iherman to update the property diagram.
|
Still requires that @iherman update the property diagram to be consistent. |
|
Indeed. I have already changed the 'source' file on my disk, I have also removed header column count from the dialect. I am still waiting on the outcome of issue #444 which may also lead to a change of the diagram before I generate the SVG and PNG files. |
|
Diagram has been updated in commit 8f9caca |
…inators # Conflicts: # ns/_vocab.csv # tests/manifest.csv
gkellogg
added a commit
that referenced
this pull request
Apr 7, 2015
changed line terminator to be an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support the ‘best practice CSV’ which allows either CRLF or
LF line terminators.