Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alsoKnownAsis being defined in ActivityStreams, right?We will also want to either 1) define the
asprefix -- which we probably shouldn't do, or 2) use full URLs everywhere -- which will bloat the document, but since it's cached, that shouldn't matter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why shouldn't we define the
asprefix? I had expected to do that, but ivan beat me to the PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhiaro I think because defining prefixes is now considered some kind of anti pattern....
w3c-ccg/security-vocab#57
as is using URLs that don't exist to define vocabulary :)
I'd prefer to see the full stable URL added here.
something like https://www.w3.org/TR/activitystreams-core/#alsoKnownAs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it would be defined near here https://www.w3.org/TR/activitystreams-vocabulary/#dfn-id ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL would be https://www.w3.org/ns/activitystreams#alsoKnownAs
It would be an extension to ActivityStreams, rather than an addition to core (amending the REC is basically impossible without a WG responsible for it at the moment). Getting it added as an extension will need to go through the Social CG, which is something I'm trying to kick off but don't have an ETA yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's defined in the DID Core spec. That has just been merged into the ED. Then it would be (if all goes to plan) added to the AS2 JSON-LD context and namespace doc which links to the spec definition in DID Core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iherman @msporny will did core have a similar document?
https://www.w3.org/TR/activitystreams-core/
https://www.w3.org/ns/activitystreams#alsoKnownAs
https://www.w3.org/TR/did-core/
https://www.w3.org/ns/did/#alsoKnownAs
?
What is the difference between the document we would need for
https://www.w3.org/ns/did/and the did spec registries?.... seems like a lot of code / term duplication... between did core, did registries and some namespace document....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sidenote, I was curious about this, so I setup this site:
https://ns.did.ai/did/#publicKeyJwk
^ if you name a file
index.json... it gets returned withcontent-typeapplication/jsonfor the URL of the directory its in.... which means....https://ns.did.ai/did/v1 works as expected....
These examples use index.md instead of index.html, but normal html is obvious also supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this term is not defined in the Activity Stream vocabulary at present it is not), and, @rhiaro said, it is defined in the DID Core specification with description and all, I do not see why this term would not be added to the did core vocabulary. I have absolutely no idea when and how the AS community will do any change on their own vocabulary, and we cannot be dependent on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OR13 wrote:
No difference...
https://www.w3.org/ns/didshould resolve to the DID Spec Registries document when text/html` is requested. We may want to sprinkle it with RDFa and/or provide an 'application/ld+json' representation of it as well. Again, not mandatory, but given the time, we would do that too.