New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added alsoKnownAs
to the context
#133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, otherwise good to go.
contexts/did-v1.jsonld
Outdated
@@ -17,6 +17,11 @@ | |||
"SchnorrSecp256k1VerificationKey2019": "sec:SchnorrSecp256k1VerificationKey2019", | |||
"X25519KeyAgreementKey2019": "sec:X25519KeyAgreementKey2019", | |||
"ServiceEndpointProxyService": "didv:ServiceEndpointProxyService", | |||
"alsoKnownAs": { | |||
"@id": "sec:alsoKnownAs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@id": "sec:alsoKnownAs", | |
"@id": "as:alsoKnownAs", |
alsoKnownAs
is being defined in ActivityStreams, right?
We will also want to either 1) define the as
prefix -- which we probably shouldn't do, or 2) use full URLs everywhere -- which will bloat the document, but since it's cached, that shouldn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why shouldn't we define the as
prefix? I had expected to do that, but ivan beat me to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhiaro I think because defining prefixes is now considered some kind of anti pattern....
as is using URLs that don't exist to define vocabulary :)
I'd prefer to see the full stable URL added here.
something like https://www.w3.org/TR/activitystreams-core/#alsoKnownAs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it would be defined near here https://www.w3.org/TR/activitystreams-vocabulary/#dfn-id ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL would be https://www.w3.org/ns/activitystreams#alsoKnownAs
It would be an extension to ActivityStreams, rather than an addition to core (amending the REC is basically impossible without a WG responsible for it at the moment). Getting it added as an extension will need to go through the Social CG, which is something I'm trying to kick off but don't have an ETA yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it would be defined near here https://www.w3.org/TR/activitystreams-vocabulary/#dfn-id ?
No, it's defined in the DID Core spec. That has just been merged into the ED. Then it would be (if all goes to plan) added to the AS2 JSON-LD context and namespace doc which links to the spec definition in DID Core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iherman @msporny will did core have a similar document?
https://www.w3.org/TR/activitystreams-core/
https://www.w3.org/ns/activitystreams#alsoKnownAs
https://www.w3.org/TR/did-core/
https://www.w3.org/ns/did/#alsoKnownAs
?
What is the difference between the document we would need for https://www.w3.org/ns/did/
and the did spec registries?.... seems like a lot of code / term duplication... between did core, did registries and some namespace document....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sidenote, I was curious about this, so I setup this site:
https://ns.did.ai/did/#publicKeyJwk
^ if you name a file index.json
... it gets returned with content-type
application/json
for the URL of the directory its in.... which means....
https://ns.did.ai/did/v1 works as expected....
These examples use index.md instead of index.html, but normal html is obvious also supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this term is not defined in the Activity Stream vocabulary at present it is not), and, @rhiaro said, it is defined in the DID Core specification with description and all, I do not see why this term would not be added to the did core vocabulary. I have absolutely no idea when and how the AS community will do any change on their own vocabulary, and we cannot be dependent on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OR13 wrote:
What is the difference between the document we would need for https://www.w3.org/ns/did/ and the did spec registries?
No difference... https://www.w3.org/ns/did
should resolve to the DID Spec Registries document when text/html` is requested. We may want to sprinkle it with RDFa and/or provide an 'application/ld+json' representation of it as well. Again, not mandatory, but given the time, we would do that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had attempted to define it here #132 But I have since removed the JSON-LD side of it, pending a URL that is useable. |
This is the issue I raised w3c/did-core#404. My answer is that yes, it must/should.
In my view, the basic difference is that the registries document is to ensure the extension mechanism for the community. It is not a normative document, only the DID-Core is. In other words, although it can mention the terms of DID Core, it cannot replace a normative specification that is part of the DID Core spec. |
I've happy to help setup https://www.w3.org/ns/did/... thats the reason I was initially interested in working on the registries. |
@OR13 thanks. By now the set up of vocabularies on |
My understanding was that https://www.w3.org/ns/did should resolve to the DID Spec Registries HTML doc when text/html is requested (eg. by a browser). Otherwise it should respond with the JSON-LD context when JSON is requested. So no duplication of work for the human-readable vocab listing is required. |
does this mean that every term defined in did core must also be defined in the did spec registries? or the ns will have gaps? |
Yes. Everything, no gaps. A lifetime ago I was trying to argue that only extensions need to go in the Registries, and the agreement was reached that everything needs to go in the Registries, including everything defined in DID Core. Note - nothing is "defined" in the Registries, but listed and their definitions elsewhere (including DID Core) are linked to. |
does this include ... thinking though this, to make sure we all get on the same page...
|
@OR13 wrote:
Nope and nope... corrections:
There are other variations we could discuss, the absolute minimum is:
|
Did Core or DID spec registries? The document should go to the same document, and the fragment ID should point into that document. Also: we now have
Talking about vocabularies I would also add a turtle version, with conneg We are running ahead of ourselves. We do not have the vocabulary file agreed upon, and that is really the important part. Setting up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will accept this PR when the URL exists :)
The URL exists! https://www.w3.org/ns/activitystreams#alsoKnownAs And the term is in the AS2 JSON-LD context. A successful collaborative effort between the DID WG and the Social Incubator Community Group 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggested change is to use the full URL for the term in the ActivityStreams 2.0 namespace
Co-authored-by: Amy Guy <amy@rhiaro.co.uk>
Note that, although I used the
sec:
vocabulary, the property itself is not present in that vocabulary document. This must be done separately.