Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore contact names for did:erc725 #368

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

peacekeeper
Copy link
Contributor

This method had 3 contact names, but only 1 was added in 6a3edac.

Maybe one thing that got lost in #353 and #357 is the ability to have separate contact emails for multiple contacts. That could be good :)

@msporny
Copy link
Member

msporny commented Nov 16, 2021

Maybe one thing that got lost in #353 and #357 is the ability to have separate contact emails for multiple contacts. That could be good :)

Yes, it got lost, however, I don't think we should have multiple contact names for a DID Method. If people want multiple people, do that behind a single email address. My reasoning is this: If there are multiple contacts, it's not clear who is going to take action when we need something done. In some cases, each of the contacts may think that the other person is on it/is going to respond. It's a failure mode we don't want, so let's make this easy on the Editors -- each DID Method registered has ONE contact email address.

@OR13 OR13 merged commit 58cbd78 into main Nov 16, 2021
@OR13
Copy link
Contributor

OR13 commented Nov 16, 2021

@msporny I read your reply too late... this is why CI rules for PR approvals are better than trusting editors :)

Comment on lines +5 to 6
"contactName": "Markus Sabadello, Fabian Vogelsteller, Peter Kolarov",
"contactEmail": "markus@danubetech.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the question here is "Who is ultimately responsible for the DID Method?" -- there should be ONE point of contact. The email could be "erc725@danubetech.com" (which will forward emails on to all of the contact names).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree there should just be one point of contact.

@msporny
Copy link
Member

msporny commented Nov 16, 2021

@msporny I read your reply too late... this is why CI rules for PR approvals are better than trusting editors :)

I had a pending "Request changes" on this PR (which I can't submit now because it was merged) -- forgot to hit submit. Please undo. We need to discuss how we're handling this.

OR13 added a commit that referenced this pull request Nov 16, 2021
@OR13
Copy link
Contributor

OR13 commented Nov 16, 2021

Reverting per the request, https://github.com/w3c/did-spec-registries/pull/371/files

OR13 added a commit that referenced this pull request Nov 16, 2021
@peacekeeper
Copy link
Contributor Author

Why revert? The question of a single or multiple contacts should be discussed in a separate issue, if at all. It should not hold up this specific PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants