Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore contact names for did:erc725 (again) #373

Merged
merged 1 commit into from
Nov 20, 2021
Merged

Restore contact names for did:erc725 (again) #373

merged 1 commit into from
Nov 20, 2021

Conversation

peacekeeper
Copy link
Contributor

Not sure why #368 was reverted in #371. Trying again.

@OR13
Copy link
Contributor

OR13 commented Nov 17, 2021 •
edited

@peacekeeper @msporny asked for it to be reverted, I didn't see his feedback here:

#368 (comment)

You replied:

I agree there should just be one point of contact.

OR13
OR13 reviewed Nov 17, 2021
View reviewed changes
methods/erc725.json
@@ -2,8 +2,8 @@
"name": "erc725",
"status": "registered",
"verifiableDataRegistry": "Ethereum",
"contactName": "Fabian Vogelsteller",
"contactName": "Markus Sabadello, Fabian Vogelsteller, Peter Kolarov",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"contactName": "Markus Sabadello, Fabian Vogelsteller, Peter Kolarov",
"contactName": "Markus Sabadello",

OR13
OR13 requested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contactName should be a single entity, either a person or an organization.

@TallTed TallTed mentioned this pull request Nov 17, 2021
Open
@peacekeeper
Copy link
Contributor Author

contactName should be a single entity, either a person or an organization.

I think @msporny 's comment in #368 (comment) was about having a single contact email, not necessarily a single contact name. I agree with this.

There are lots of DID methods that have multiple names as contact.

This PR is only trying to fix a mistake that happened during the JSON conversion in #353, nothing else. If we want to remove multiple contact names, then this should be done in a separate PR, for all DID methods.

@OR13
Copy link
Contributor

OR13 commented Nov 18, 2021

@msporny please review, I reverted the merge based on you request, happy to merge if you agree with @peacekeeper .

msporny
msporny approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@msporny msporny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Markus' corrections -- having three contact names is fine, the thing that's most important is the single contactEmail, IMHO. I'm good w/ merging as-is.

@msporny msporny force-pushed the peacekeeper-erc725-contacts-again branch from 03632eb to 7f11dbe Compare November 20, 2021 17:02
@msporny
Copy link
Member

msporny commented Nov 20, 2021

Editorial, multiple reviews, no remaining objections, merging.

@msporny msporny merged commit 75a37b2 into main Nov 20, 2021
@msporny msporny deleted the peacekeeper-erc725-contacts-again branch November 20, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 requested changes

@msporny msporny msporny approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

@mprorock mprorock Awaiting requested review from mprorock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peacekeeper @OR13 @msporny @kdenhartog