Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding the Italian translation for the scope note mentioned in issue 980 #1004

Merged
merged 7 commits into from
Jul 18, 2019
Merged

adding the Italian translation for the scope note mentioned in issue 980 #1004

merged 7 commits into from
Jul 18, 2019

Conversation

riccardoAlbertoni
Copy link
Contributor

Fixing syntax issue for issue #980 and added Italian translation of the ScopeNote

@riccardoAlbertoni
Copy link
Contributor Author

This fixes the syntax issue in pr #1003, and adds the Italian translation for the scope note

@riccardoAlbertoni riccardoAlbertoni mentioned this pull request Jul 17, 2019
Merged
@agbeltran agbeltran added this to the DCAT CR milestone Jul 17, 2019
@riccardoAlbertoni riccardoAlbertoni changed the title Fixing syntax issues for issue 980 adding the Italian translation for the scope note mentioned in issue 980 Jul 17, 2019
@riccardoAlbertoni
Copy link
Contributor Author

@agbeltran: do you have any objection if I merge this pull in your PR 1003?
Otherwise, I can move this to be merged directly in gh-pages but I am not sure how that would work after your force-push ...

@agbeltran
Copy link
Member

Hi @riccardoAlbertoni - I don't think there is a need to merge this into #1003 - both PRs can be merged independently into gh-pages as they are dealing with different issues (as I removed any syntactic changes from #1003 and those fixes were dealt with in #1006 - unless I'm not following why you see the need to merge them?

@riccardoAlbertoni riccardoAlbertoni changed the base branch from agb-issue980 to gh-pages July 18, 2019 11:07
@riccardoAlbertoni
Copy link
Contributor Author

Hi @riccardoAlbertoni - I don't think there is a need to merge this into #1003 - both PRs can be merged independently into gh-pages as they are dealing with different issues (as I removed any syntactic changes from #1003 and those fixes were dealt with in #1006 - unless I'm not following why you see the need to merge them?

Fine, I have changed the base to which this PR is going to merge. Thanks.

@agbeltran
Copy link
Member

Fine, I have changed the base to which this PR is going to merge. Thanks.

Sounds good, thanks.

riccardoAlbertoni
riccardoAlbertoni commented Jul 18, 2019
View reviewed changes
dcat/rdf/dcat.ttl Outdated Show resolved Hide resolved
@riccardoAlbertoni
Copy link
Contributor Author

@davebrowning the merge of 1003 seems to have a missing ";" and an unproperly close multiline literal (opened with """ and closed by ")

please consider merging also Pr #1004 which adds Italian translation and solves the syntactic issue

@davebrowning davebrowning merged commit 99315cf into gh-pages Jul 18, 2019
@davebrowning
Copy link
Contributor

Hopefully that brings it all back together?

@davebrowning davebrowning deleted the dcat-issue980-fixingTTL branch July 18, 2019 12:20
@riccardoAlbertoni
Copy link
Contributor Author

yes, I checked and I think so. Anyway, dcat.ttl is parsable again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agbeltran agbeltran agbeltran approved these changes

@davebrowning davebrowning davebrowning approved these changes

@dr-shorthair dr-shorthair Awaiting requested review from dr-shorthair

@andrea-perego andrea-perego Awaiting requested review from andrea-perego

@pwin pwin Awaiting requested review from pwin

Assignees
No one assigned
Labels
dcat Editorial
Projects
None yet
Milestone
DCAT CR
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardoAlbertoni @agbeltran @davebrowning