Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to scopeNote for dcat:Resource according to issue #980 #1003

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

agbeltran
Copy link
Member

Addressing #980

@agbeltran
Copy link
Member Author

It also addresses some syntacting issues that were causing parsing the ttl file to fail.

Copy link
Contributor

@riccardoAlbertoni riccardoAlbertoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for the merge - The TTL still has problems according to the RDFCAt provided by JENA.
I am afraid that removing the multiline literals ( those between """) when literals are multi lined worsen the syntax issue. @agbeltran Is it ok for you if I try to fix this up?

@agbeltran
Copy link
Member Author

agbeltran commented Jul 17, 2019

Sure - I can roll back the syntactic changes but those were giving issues with the OWLAPI parser. I guess I would rely on the Jena one more anyway. I'll see if I get some time to set this up as a Continous Integration check for each PR.

@riccardoAlbertoni
Copy link
Contributor

riccardoAlbertoni commented Jul 17, 2019

Sure - I can roll back the syntactic changes but those were giving issues with the OWLAPI parser.

That is inspiring, I am going to check in a separate PR if getting rid of the multiline literals is the key to progress on the issues 944.
I have already rolled back your changes on multiline literal in my PR #1004, there were also other missing semicolons I have fixed. Just merge my PR #1004 to your PR #1003, and we should be ok for this issue.

@dr-shorthair
Copy link
Contributor

This might be the issue - see #944 (comment)
I've fixed it in https://github.com/w3c/dxwg/tree/dcat-issue-944

@agbeltran
Copy link
Member Author

OK - I've reverted the syntactic fixes as these are now dealt with in #944 - this PR only addresses #980 and can be merged after review

@davebrowning davebrowning merged commit 247640d into gh-pages Jul 18, 2019
@davebrowning davebrowning deleted the agb-issue980 branch July 18, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants