Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated section "Token mappings" #1075

Merged
merged 4 commits into from
Sep 15, 2019

Conversation

larsgsvensson
Copy link
Contributor

Updated normative text on how to use the Link header
Removed Note about "Alternate ways of conveying URI / token mappings" as per #1064

Preview at https://raw.githack.com/w3c/dxwg/larsgsvensson-update-token-mappings/conneg-by-ap/index.html#listprofiles-tokens

Since this introduces normative text, please review carefully and also please don't merge until we've had @RubenVerborgh's review

Updated normative text on how to use the `Link` header
Removed Note about "Alternate ways of conveying URI / token mappings" as per #1064
Copy link
Member

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and confirmed technically accurate.

As an editorial note, I wonder whether we need the concept of a "token / URI mapping". We might be able to write down the same thing by just referring to tokens. Will add optional suggestion as comment.

need to provide a <a>token</a> / URI mapping via this <strong>list profiles</strong> function. In this
HTTP functional profile of this specification, this may be implemented in a number of ways. The preferred
way is to add "token" parameters to the HTTP Content-Profile and Link HTTP headers.
need to provide a <a>token</a> / URI mapping via this <strong>list profiles</strong> function.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could write this instead as "needs to indicate for every supported token to which profile URI it corresponds". This eliminates the concept of a "token / URI mapping" (and associated questions such as whether it needs to be complete, injective, etc.).

Copy link
Contributor

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a couple of small HTML things, now all approved

@nicholascar nicholascar merged commit b7969a2 into gh-pages Sep 15, 2019
@nicholascar nicholascar deleted the larsgsvensson-update-token-mappings branch September 15, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants