Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizing URI for examples #1487

Closed
wants to merge 18 commits into from
Closed

Harmonizing URI for examples #1487

wants to merge 18 commits into from

Conversation

agbeltran
Copy link
Member

@agbeltran agbeltran commented Mar 22, 2022

This PR includes

  • changed the examples URI in the DCAT3 example files (under the /examples/vocab-dcat-3 folder)
  • validated all the files
  • changed the example URIs in the spec

Preview: https://raw.githack.com/w3c/dxwg/dcat-issue-1467/dcat/index.html

Diff: https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fw3c.github.io%2Fdxwg%2Fdcat%2F&doc2=https%3A%2F%2Fraw.githack.com%2Fw3c%2Fdxwg%2Fdcat-issue-1467%2Fdcat%2Findex.html

@agbeltran agbeltran added this to the DCAT3 4PWD milestone Mar 24, 2022
@agbeltran agbeltran linked an issue Mar 24, 2022 that may be closed by this pull request
@agbeltran agbeltran marked this pull request as ready for review March 25, 2022 10:13
@riccardoAlbertoni
Copy link
Contributor

Thanks, @agbeltran for your efforts. This PR has already improved a lot the examples' consistency.

I have two observations:

  • it seems that not all the RDF examples are updated. For example, basic-example.ttl still uses some  http://example.org/..., whereas this PR changes the correspondent part in the HTML. Have you pushed all the GIT commits you had in your local copy of the repository?
  • In the HTML, we use ex:, :, and  a:, to refer to fictional example URIs. Moreover, in some cases, the namespace in the HTML is denoted by ":" in the HTML  corresponds to ex: in the RDF,  I wonder if we want to pick one among ":" or "ex" uniformize the examples in the HTML and RDF accordingly. 

@riccardoAlbertoni
Copy link
Contributor

Thanks, I have noticed still some inconsistencies. Merging the PR #1497 should get rid of them.

@agbeltran
Copy link
Member Author

thanks @riccardoAlbertoni - I'll have a look (but I am still going through the spec and examples and have uncommitted changes)

@agbeltran agbeltran marked this pull request as draft April 1, 2022 09:18
@agbeltran
Copy link
Member Author

PR replaced by #1500

@agbeltran agbeltran closed this Apr 8, 2022
@agbeltran agbeltran deleted the dcat-issue-1467 branch April 8, 2022 11:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonizing the namespaces for example URIS
4 participants