Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 644 #734

Merged
merged 4 commits into from
Feb 25, 2019
Merged

Issue 644 #734

merged 4 commits into from
Feb 25, 2019

Conversation

nicholascar
Copy link
Contributor

Addresses Issues https://github.com/w3c/dxwg/issues/643 & #644: "prof:isTransitiveProfileOf needs more convincing case and/or example" & "Specify the semantics of prof:isTransitiveProfileOf wrt prof:isProfileOf" in separate commits.

@nicholascar nicholascar added the profiles-vocabulary For discussion of profile description vocabulary label Feb 6, 2019
@nicholascar nicholascar added this to the PROF 2PWD milestone Feb 6, 2019
@nicholascar nicholascar added this to To do in Profiles Ontology via automation Feb 6, 2019
@aisaac
Copy link
Contributor

aisaac commented Feb 15, 2019

@nicholascar would it be possible to split this PR? I believe that the commit for isTransitiveProfileOf semantics is fine, and we could close issue #644 , but in the current state I think the example is not right enough for closing #643 . Separating them would allow the latter to not block the former!

@aisaac
Copy link
Contributor

aisaac commented Feb 20, 2019

@nicholascar @rob-metalinkage @kcoyle the discussion on PROF examples yesterday and on #745 makes me realize that we may block something useful if this PR is not merged. In that case it can be merged, but by all means it shouldn't mean that the corresponding issues can be closed now!
(even though I still think that #644 could be closed, and that splitting this PR would have been ideal...)

@nicholascar
Copy link
Contributor Author

Thanks @aisaac, we’ll get this merged, leave the issues open and in the future I’ll try and make more granular PRs that try and tackle single smaller things each. That should make approving bits easier and reduce the chance of things being held up!

@rob-metalinkage rob-metalinkage merged commit d5799c4 into gh-pages Feb 25, 2019
Profiles Ontology automation moved this from To do to Done Feb 25, 2019
@nicholascar nicholascar deleted the Issue-644 branch February 25, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiles-vocabulary For discussion of profile description vocabulary
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants