-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prof examples #745
Prof examples #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicholascar , it is not clear to me why the examples have been moved to separate files. I thought the intention was to maintain them separately from the spec, and loading them dynamically via @data-include
(see https://github.com/w3c/respec/wiki/data--include), but I saw that the examples are already included in the spec.
"... Profiles Ontology which is, itself, a profile of the Dublin Core Terms vocabulary." This use of "profile of" has been questioned by Tom Baker, who is the main expert on the Dublin Core Terms, and should not be included here until it has been resolved. |
@andrea-perego I think this is just a not-sorted-out-yet problem. We've always had both example files in example/ and also some examples in the spec itself. Simon and others have recently hassled me about putting examples right up front in the spec. Since I have to keep updating examples when the spec changes, I like the idea of only one place to go to update them all so perhaps we can aim to put all examples in examples/ and then do as you suggest to load them dynamically. I guess I've begun a process of placing all examples in examples/ already but I'll make it a goal to have them all in there and included across to the spec for the 3PWD. |
@kcoyle the use of isProfileOf of Dublin Core is correct as PROF is constructed now. I agree that there’s a need, highlighted by Tom Baker, to define Standards/Profiles v. Namespaces and examples like these help with that as they put the vocab as it currently is to the test. Some of the discussion at the plenary meeting I missed this morning would have benefitted from up-to-date PROF examples, even if that was to indicate where everyone thinks they are wrong! So please allow this PR through so we can iterate on top of it. If it is held back - it updates all examples so much more than just PROF’s profile - we stall progress. For me, the process of improving models is theory followed by test implementations (examples) and then iterations on top of those. |
The conflicts this PR now has are due to my other PR to revamp PROF from Ontology to Vocab having been metered. Should be easy to sort out this merge preserving the Vocabulary name. |
Go ahead and merge and we'll sort out the "profile of" question later. |
# Conflicts: # profilesont/examples/README.md # profilesont/examples/dcat.svg # profilesont/examples/hierarchy.svg
# Conflicts: # profilesont/examples/README.md # profilesont/examples/dcat-ap.svg # profilesont/examples/ga.svg # profilesont/index.html # profilesont/profilesont.vsdx
All examples separated into individual files, all RDF properties updated to match ontology, diagrams delivered as SVG, colour coding used instead of rdf:type relations.