Implementing proposals to address #83 & #85 #807
Conversation
andrea-perego
changed the title
andrea-perego
requested review from
agbeltran,
davebrowning,
dr-shorthair,
riccardoAlbertoni and
pwin
|
I've moved this back into DCAT CR in the hope we can incorporate it in the CR. If review indicates we need a longer discussion then we can defer it to Future work again. |
I've done this, and also consolidated some other temporal examples into new (informative) section https://rawgit.com/w3c/dxwg/andrea-perego-dcat-rev-temporal-spatial-coverage/dcat/index.html#time-and-space |
|
I think this is good to go now. Since these are substantive changes, they need approval by DCAT team. |
- Editorial fixes everywhere - Started harmonising Turtle notation in examples and fixed some syntax errors - Started harmonising use of whitespace and indentation in Turtle examples - Replaced rdfs:comment in example with dct:title or dct:description (as appropriate) - Added pointer to Example 3 in Section 11.2 as an example of the use of dcat:spatialResolutionInMeters - Validated HTML markup
|
@dr-shorthair said:
+1 from me. I just added some additional editorial changes, and validated HTML markup - see commit d10f88e |
|
Sterling work guys One minor thing: there is still an issue NOTE to #85. More importantly, I get a http 403 for the Europa.eu link at line 3057? @andrea-perego can you suggest something more public? Apart from that it looks good to me |
|
@davebrowning said:
Thanks for pointing this out. I think it is a temporary issue, but I will check. |
|
@andrea-perego said:
Yes, just realised I get the same error from gh-pages... |
- Added entries for classes on spatial and temporal coverage, and the new section "Time and space" - Started harmonising changelog
|
@davebrowning said:
Thanks, and I also now realise we have not updated the changelog. I just made a commit commenting the issue NOTE, and updating the changelog (2d8422d) |
|
We should also copy all the code fragments/examples into ttl files in https://github.com/w3c/dxwg/tree/gh-pages/dcat/examples |
|
@dr-shorthair said:
I will take care of that. |
|
BTW, are you all happy with the current geometry examples - build upon the SDW BP ones? If yes, I will delete the .png files with the map previews of the original examples. |
Yes, I like the section "Time and space". I wonder if we should add the support on representing time and space coverage in the "items" listed in the "Status of This Document".
In my very modest opinion, the .png files do not make any harm, they might help people not familiar with the concepts such as centroid, BB, etc. Anyway if you think otherwise, I do not object to deleting them |
|
@riccardoAlbertoni said:
Just for clarity: the .png files of the current examples will be kept. But we have still the .png files of the old examples, and they are not used any longer. These are the ones I was considering to delete, provided that we don't want to switch back to the original examples. |
|
What's used in the document works for me. Probably less confusing to delete the unused ones, but I don't feel strongly about it. |
|
It's for keeping folders clean from unused / unnecessary files. I have a back-up copy of everything, anyway. |
|
I think we're done here. I'd like to notify this PR (and the underlying issues) in the Plenary agenda for today's meeting as per usual process (to flag up the work), so will merge before then, unless someone shouts. We can handle any issues arising under a separate PR, hopefully just of editorial nature |
See:
Preview here (BTW, rawgit is now down):