Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prof examples #830

Merged
merged 12 commits into from
Mar 26, 2019
Merged

Prof examples #830

merged 12 commits into from
Mar 26, 2019

Conversation

nicholascar
Copy link
Contributor

@nicholascar nicholascar commented Mar 19, 2019

Updates to SVG to remove colour and add white backgrounds.

This PR was initially branched from other unrelated branches (for property definitions & alignments, subjects of PRs #827 & #828 respectively) so I've removed those PRs changes by reverting 3 commits.

This PR should now only contain edits to examples - the section in the HTML doc and files within examples/ - and a small chift of non-example figures to a new figures/ folder for neatness of source files.

@nicholascar nicholascar added the profiles-vocabulary For discussion of profile description vocabulary label Mar 19, 2019
@nicholascar nicholascar added this to the PROF 2PWD milestone Mar 19, 2019
@nicholascar nicholascar added this to To do in Profiles Ontology via automation Mar 19, 2019
Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial and formatting improvements and non-normative examples.

@rob-metalinkage rob-metalinkage requested review from agbeltran, aisaac, kcoyle and makxdekkers and removed request for agbeltran and makxdekkers March 19, 2019 22:06
@nicholascar
Copy link
Contributor Author

nicholascar commented Mar 20, 2019

See this preview of the changed document: https://raw.githack.com/w3c/dxwg/prof-examples/profilesont/index.html#examples

Copy link
Contributor

@aisaac aisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with doing these changes. I must say though that I may still have some comments on existing examples and diagrams, and I am not sure that this PR fixes any of the outstanding issues.
But at this point I am convinced that we need to see the new version to facilitate further discussion and feedback and move forward.

I also have one doubts: one of the commits seem to add at least one significant example, the CSIRO one:
912a211
(actually I think in total three examples are added)
Again I'm not against showing it for discussion, but I didn't have the time to check it.

And I am quite sure that this makes this PR a non-editorial one, so I'm going to remove the 'editorial' label to it

Profiles Ontology automation moved this from To do to In progress Mar 26, 2019
@aisaac aisaac removed the Editorial label Mar 26, 2019
@aisaac aisaac merged commit 5e7e6f6 into gh-pages Mar 26, 2019
Profiles Ontology automation moved this from In progress to Done Mar 26, 2019
@nicholascar
Copy link
Contributor Author

Thanks Antoine. The example you mention that was added - the CSIRO one - was already there but as a loose example in the examples/ folder, not added into the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiles-vocabulary For discussion of profile description vocabulary
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants