-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prof examples #830
Prof examples #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial and formatting improvements and non-normative examples.
See this preview of the changed document: https://raw.githack.com/w3c/dxwg/prof-examples/profilesont/index.html#examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with doing these changes. I must say though that I may still have some comments on existing examples and diagrams, and I am not sure that this PR fixes any of the outstanding issues.
But at this point I am convinced that we need to see the new version to facilitate further discussion and feedback and move forward.
I also have one doubts: one of the commits seem to add at least one significant example, the CSIRO one:
912a211
(actually I think in total three examples are added)
Again I'm not against showing it for discussion, but I didn't have the time to check it.
And I am quite sure that this makes this PR a non-editorial one, so I'm going to remove the 'editorial' label to it
Thanks Antoine. The example you mention that was added - the CSIRO one - was already there but as a loose example in the examples/ folder, not added into the document. |
Updates to SVG to remove colour and add white backgrounds.
This PR was initially branched from other unrelated branches (for property definitions & alignments, subjects of PRs #827 & #828 respectively) so I've removed those PRs changes by reverting 3 commits.
This PR should now only contain edits to examples - the section in the HTML doc and files within examples/ - and a small chift of non-example figures to a new figures/ folder for neatness of source files.