Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making qsa realization for conneg non-normative #898

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

agreiner
Copy link
Contributor

I modified the introduction to the QSA info and also reworked the text to make it clear that other URL schemes are okay. The last sentence of the QSA section was cut off, so I'm not sure what was missing. I filled in some text that seemed close to what would have been intended.

We need to keep the realization specific - QSAs - as opposed to other potential URL-based approaches.

We shouldn't refer always to "datasets" in examples as Profile Neg could be used for other things too.
Copy link
Contributor

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good - I like the changes Annette.

I've just dropped back to QSA in the Realization's title as this is necessary to keep the realization confined since the wording you had might crowd out other URL-based approaches. Also, I removed a change you made about using "dataset" in examples as this shouldn't be limited to datasets.

Copy link
Contributor

@larsgsvensson larsgsvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this reads nice and balanced. Thank you @agreiner and @nicholascar

@larsgsvensson larsgsvensson merged commit f4c7d91 into w3c:gh-pages Apr 16, 2019
Content Negotiation by Profile automation moved this from In progress to Done Apr 16, 2019
@agreiner
Copy link
Contributor Author

No problem to change the word dataset there. My intention was to make the URL match what was described. The original isn't at all valid, which obscures the point you're trying to demonstrate. I think my "bad" example has an error, too, since it doesn't have the ?. It's possible I'm not understanding your point, though. It seems to me that one could legitimately use additional key/value pairs that are exposed to the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants