Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tarball #241

Merged
merged 8 commits into from
Dec 9, 2015
Merged

Support for tarball #241

merged 8 commits into from
Dec 9, 2015

Conversation

deniak
Copy link
Member

@deniak deniak commented Dec 8, 2015

That PR aims at allowing tarballs in echidna.
The tarball is expected to contain an Overview.html file as required by pubrules.

@tripu I'm assigning you as the reviewer but @plehegar, your feedback is welcome.

Note: .tgz and .tar.gz are not supported.

Fix #230

@plehegar
Copy link
Member

plehegar commented Dec 8, 2015

Using mime type to detect the file type might be unreliable. How about checking that you find "ustar" at byte 257?
https://en.wikipedia.org/wiki/Tar_%28computing%29

@deniak
Copy link
Member Author

deniak commented Dec 8, 2015

The module file-type is checking the magic number to identify the type (see l.95).

@plehegar
Copy link
Member

plehegar commented Dec 8, 2015

@deniak ok. thanks.

@tripu
Copy link
Member

tripu commented Dec 9, 2015

@deniak, I'd put your new test under the section fetchAndInstall(url, dest) to have it nicely grouped like the rest. And sort dependencies in package.json alphabetically.

Apart from that, OK to merge!

Sort modules in packages.json
deniak added a commit that referenced this pull request Dec 9, 2015
@deniak deniak merged commit aca8e13 into master Dec 9, 2015
@deniak deniak deleted the denis/tarball branch December 9, 2015 09:34
@deniak
Copy link
Member Author

deniak commented Dec 9, 2015

@tripu thanks for the review

@plehegar
Copy link
Member

plehegar commented Dec 9, 2015

@deniak many thanks! let me know when this gets deployed. I'd like to test it with a publication.

@deniak
Copy link
Member Author

deniak commented Dec 10, 2015

@plehegar we just deployed v1.5.0. Feel free to publish your tar files.

@deniak deniak mentioned this pull request Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants