-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tarball #241
Support for tarball #241
Conversation
Using mime type to detect the file type might be unreliable. How about checking that you find "ustar" at byte 257? |
@deniak ok. thanks. |
@deniak, I'd put your new test under the section Apart from that, OK to merge! |
Sort modules in packages.json
@tripu thanks for the review |
@deniak many thanks! let me know when this gets deployed. I'd like to test it with a publication. |
That PR aims at allowing tarballs in echidna.
The tarball is expected to contain an
Overview.html
file as required by pubrules.@tripu I'm assigning you as the reviewer but @plehegar, your feedback is welcome.
Note:
.tgz
and.tar.gz
are not supported.Fix #230